Linter fixes #45
Merged
Linter fixes #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xchoo
requested changes
Nov 11, 2019
xchoo
requested changes
Nov 11, 2019
xchoo
approved these changes
Nov 12, 2019
- Upgrade to Bones 0.7.0
- fpga_pes_ensemble_network:
- Changed default socket_args (W0102: dangerous-default-value)
- Fixed logger args (W1201: logger-not-lazy)
- C901: too complex:
- Break out function to determine output dim on init
- Break out function to validate network params in builder
- Break out function for ssh authorization and connection
- Break out function for ssh error handling
- 00-mnist_vision_network.py:
- Change arg names for resize_img func
(W0621: redefined-outer-name)
- 01-adaptive_pendulum.py:
- Stop using locals() in string formatting
(W0641: possibly-unused-variable)
- 02-RL_demo.py:
- Create a local page variable (E0602: undefined-variable)
- Create local world_cfg variables (W0621: redefined-outer-name)
(W0102: dangerous-default-value)
- Add dictionary to process keyboard inputs (C901: too complex)
- Create class to store persistent learning state
- grid.py (originally entire file was ignored):
- R0205: useless-object-inheritance
- W0611: unused-import
- Add returns to all branches in go_torward and save funcs
(R1710: inconsistent-return-statements)
- Replace builtin file func with open (E0602: undefined-variable)
- id_extractor.py:
- Break out function for ssh authorization and connection
(C901: too complex)
bmorcos
force-pushed
the
linter-fixes
branch
from
27c3099
to
a32cd93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
We want NengoFPGA to be pure with no ignored linter/style errors!
Interactions with other PRs:
Will need to be rebased on #44 but that should be straightforward
How has this been tested?
Tested functional changes using the examples, I didn't hit every logger line (modified for
logger-not-lazy), but that is pretty safe I think.How long should this take to review?
Where should a reviewer start?
Most involved changes were definitely the
function too complexmods in the 3rd commit, take a look at that more in depth... everything else should be minor style changes.Types of changes:
Checklist: