Cortical rule modifies vocab

[jgosmann]

When I add a cortical rule like a = b in a SPA module all semantic pointers in a's vocabulary are added to b's vocabulary. That doesn't make sense to me (the other direction would make somewhat sense) and is annoying because I have semantic pointers in a's vocabulary that should not be in b's vocabulary (i.e., the 'YES' pointer of the comparison).

[xchoo]

Yup! This issue was brought up in #696, and an attempt to get around this is sort of implemented here, using a read-only flag on vocabularies. #699. (Although, I just noticed that if you try to add to a read only vocabulary, it will raise an error when I think it should raise a warning instead).

[jgosmann]

As this is a duplicate of #696 which has been resolved, this can be closed as well. :)

[tbekolay]

Feels good seeing all these issues closed! 😍 🎉 🌈