Fix synapse filt to allow list as input #1123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a bug where
Synapse.filt
could not accept a list as input.Motivation and context:
Lowpass(0.005).filt([1, 0, 0])
would raise the errorAttributeError: 'list' object has no attribute 'dtype'
. There is no issue for this bug.How has this been tested?
Changed a test from
u
->list(u)
.Where should a reviewer start?
One line in
synapses.py
.How long should this take to review?
Types of changes:
Checklist: