Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug with ShapeParam.coerce returning None #1342

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Fixed bug with ShapeParam.coerce returning None #1342

merged 1 commit into from
Aug 23, 2017

Conversation

hunse
Copy link
Collaborator

@hunse hunse commented Aug 9, 2017 •
edited by tbekolay
Loading

Motivation and context:

Just a simple oversight. This will now be tested in nengo_extras, so hopefully it will be more robust.

I don't have time to add a test for this, but if someone else wants to add one, I'm sure it wouldn't hurt. Ditto with the changelog entry.

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hunse hunse mentioned this pull request Aug 9, 2017
Merged
@jgosmann jgosmann self-assigned this Aug 11, 2017
tbekolay
tbekolay approved these changes Aug 13, 2017
View reviewed changes
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2e1715d to test the change (those assertion statements fail on master). LGTM, thanks!

@hunse
Copy link
Collaborator Author

hunse commented Aug 13, 2017

I think your last fixup is targeting the wrong commit, otherwise it all looks good to me.

@tbekolay
Copy link
Member

I think your last fixup is targeting the wrong commit

Noticed after I pushed, didn't want to force push a fix (I squash manually anyhow).

@jgosmann jgosmann removed their assignment Aug 16, 2017
@tbekolay tbekolay merged commit 23f51ee into master Aug 23, 2017
@tbekolay tbekolay deleted the fix-shapeparam branch August 23, 2017 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbekolay tbekolay tbekolay approved these changes

@jgosmann jgosmann jgosmann approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hunse @tbekolay @jgosmann