Pass x as copy to nodes. #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,6 +40,9 @@ Release History | |||
| - The ``probeable`` attribute of all Nengo objects is now implemented | |||
| as a property, rather than a configurable parameter. | |||
| (`#671 <https://github.com/nengo/nengo/pull/671>`_) | |||
| - Node functions receive ``x`` as a copied NumPy array (instead of a readonly | |||
| view). | |||
| (`#626 <https://github.com/nengo/nengo/issues/716>`_) | |||
There was a problem hiding this comment.
Is it 626 or 716...? Presumably 722 should be in there too
|
Aside from the inline comments, this looks good to me! |
|
Fixed those. 🍰 |
|
This LGTM! Does anyone have any objections to passing x as a copy? The discussion in #716 seemed to favour copying, so if no one objects by lunch time or thereabouts, I'll merge! 🌈 |
Closes #716.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #716.