add gasclaim #6
Merged
add gasclaim #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2020 15:25
shargon
reviewed
Sep 14, 2020
| @@ -10,6 +10,8 @@ namespace CNEO | |||
| { | |||
| public class CNEO : SmartContract | |||
| { | |||
| private static readonly byte[] GasClaim = "AQzRMe3zyGS8W177xLJfewRRQZY2kddMun".ToScriptHash(); | |||
There was a problem hiding this comment.
yes, a template for someone can control the gas generated by NEO in CNEO contract.
There was a problem hiding this comment.
Remember to change it before deploy on mainnet
shargon
approved these changes
Sep 14, 2020
chenzhitong
reviewed
Sep 20, 2020
| foreach (var output in outputs) | ||
| { | ||
| if (output.ScriptHash.AsBigInteger() == currentHash.AsBigInteger()) | ||
| if (output.ScriptHash.AsBigInteger() == currentHash.AsBigInteger() && output.AssetId.AsBigInteger() == AssetId.AsBigInteger()) |
There was a problem hiding this comment.
这里应该检查所有的outputs，只有都满足条件才将 ifClaimGas 设置为 false；否则一个output满足就可以绕过这个检查，并没修复那个漏洞。
也许可以改为：
bool ifClaimGas = false;
foreach (var output in outputs)
{
if (output.ScriptHash.AsBigInteger() != currentHash.AsBigInteger() || output.AssetId.AsBigInteger() != AssetId.AsBigInteger())
ifClaimGas = true;There was a problem hiding this comment.
output.ScriptHash.AsBigInteger() != currentHash.AsBigInteger()
检查所有output的话, 比如这个判断条件会给管理员通过走ClaimGas的条件, 取走所有neo的权限
There was a problem hiding this comment.
那现在这样其它人也能提GAS吧（貌似）
如果这么改呢：
if((byte)tx.Type == 0x02)
{
return inputs == null ? Runtime.CheckWitness(GasClaim) : false;
}
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.