Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(website): upgrade web dependencies one last time #1325

Merged
merged 1 commit into from
Apr 18, 2019
Merged

chore(website): upgrade web dependencies one last time #1325

merged 1 commit into from
Apr 18, 2019

Conversation

danwbyrne
Copy link
Contributor

title. React Static 7 is the bigger one.

@codecov
Copy link

codecov bot commented Apr 15, 2019 •
edited
Loading

Codecov Report

Merging #1325 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   64.64%   64.69%   +0.05%     
==========================================
  Files        1529     1529              
  Lines       40407    40405       -2     
  Branches     3943     3943              
==========================================
+ Hits        26122    26141      +19     
+ Misses      14285    14264      -21
Flag Coverage Δ
#e2e 60.47% <ø> (+0.18%) ⬆️
#unit 62.23% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/neo-one-website/src/polyfill.ts 0% <ø> (ø) ⬆️
.../src/payload/message/ChangeViewConsensusMessage.ts 62.5% <0%> (-31.25%) ⬇️
...-node-core/src/payload/message/ConsensusMessage.ts 73.68% <0%> (-10.53%) ⬇️
...ckages/neo-one-node-core/src/utils/BinaryReader.ts 83.01% <0%> (-0.95%) ⬇️
...e-node-core/src/transaction/attribute/Attribute.ts 84.21% <0%> (+28.07%) ⬆️
...core/src/transaction/attribute/UInt256Attribute.ts 57.57% <0%> (+33.33%) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #1325 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   64.64%   64.69%   +0.05%     
==========================================
  Files        1529     1529              
  Lines       40407    40405       -2     
  Branches     3943     3943              
==========================================
+ Hits        26122    26141      +19     
+ Misses      14285    14264      -21
Flag Coverage Δ
#e2e 60.47% <ø> (+0.18%) ⬆️
#unit 62.23% <ø> (ø) ⬆️
Impacted Files Coverage Δ
packages/neo-one-website/src/polyfill.ts 0% <ø> (ø) ⬆️
.../src/payload/message/ChangeViewConsensusMessage.ts 62.5% <0%> (-31.25%) ⬇️
...-node-core/src/payload/message/ConsensusMessage.ts 73.68% <0%> (-10.53%) ⬇️
...ckages/neo-one-node-core/src/utils/BinaryReader.ts 83.01% <0%> (-0.95%) ⬇️
...e-node-core/src/transaction/attribute/Attribute.ts 84.21% <0%> (+28.07%) ⬆️
...core/src/transaction/attribute/UInt256Attribute.ts 57.57% <0%> (+33.33%) ⬆️

@codecov
Copy link

codecov bot commented Apr 15, 2019 •
edited
Loading

Codecov Report

Merging #1325 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
+ Coverage   62.22%   62.23%   +<.01%     
==========================================
  Files        1529     1529              
  Lines       40395    40393       -2     
  Branches     3940     3940              
==========================================
  Hits        25137    25137              
+ Misses      15258    15256       -2
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#unit 62.23% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...neo-one-developer-tools-frame/src/ResizeHandler.ts 0% <ø> (ø) ⬆️
packages/neo-one-website/src/polyfill.ts 0% <ø> (ø) ⬆️

afragapane
afragapane approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@afragapane afragapane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks good.

@danwbyrne
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 18, 2019
@bors @danwbyrne
Merge #1325
6098634 
1325: chore(website): upgrade web dependencies one last time r=danwbyrne a=danwbyrne

title. React Static 7 is the bigger one.

Co-authored-by: Daniel Byrne <danwbyrne@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 18, 2019

Build succeeded

@bors bors bot merged commit 3fae1db into neo-one-suite:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dicarlo2 dicarlo2 dicarlo2 approved these changes

@afragapane afragapane afragapane approved these changes

@davemneo davemneo Awaiting requested review from davemneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danwbyrne @dicarlo2 @afragapane