feat(transactions): fix all transaction stuff, rpc calls, more #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwbyrne
suggested changes
Nov 18, 2020
packages/neo-one-client-common/src/models/transaction/FeelessTransactionModel.ts
Outdated
Show resolved
Hide resolved
spencercorwin
force-pushed
the
transactions
branch
from
c3045e1
to
31bd8ac
Compare
spencercorwin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Updates many things:
createGetHashDatafunctionmessage/messageMagicis passed around to the appropriate places where it's needed (like in ConsensusPayload, FeelessTransactionModel, TransactionModel, Block, BlockBase, TrimmedBlock, BlockHeader)sendrawtransaction.test.ts)Test Plan
See
sendrawtransaction.test.tsandtemp.test.tsinneo-one-client-core/src/__tests__/provider.Also tested manually with Postman.
Alternate Designs
None.
Benefits
Less bugs, closer to Neo3 Preview 3.
Possible Drawbacks
None.
Applicable Issues
#2176
#2009
#1882
#2155