Native: extend CryptoLib's verifyWithECDsa with compatible NamedCurveHash argument
#1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
requested review from
shargon,
cschuchardt88,
Jim8y,
vncoelho,
roman-khimov and
superboyiii
19 tasks
|
@AnnaShaleva anna, we are not going to add secp256k1 support here. Core only do verification, no construction. |
|
This code is needed for verification only. In neo-project/neo#3209 we extend the native CryptoLib's |
Jim8y
previously approved these changes
May 6, 2024
vncoelho
reviewed
May 6, 2024
shargon
reviewed
May 7, 2024
Jim8y
previously approved these changes
May 10, 2024
|
Can’t be merged yet, I need to update dependencies. |
|
I imagined that, fetch git as well |
Jim8y
reviewed
May 10, 2024
tests/Neo.SmartContract.Framework.UnitTests/Services/CryptoTest.cs
Outdated
Show resolved
Hide resolved
It will be replaced by NamedCurveHash in the next commit. A part of neo-project/neo#3209. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Mark VerifyWithECDsa method as obsolete. Ref. native CryptoLib update from neo-project/neo#3209. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Use 122 and 123 respectively for secp256k1Keccak256 and secp256r1Keccak256. Port the neo-project/neo@e7d9122. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Released commit 1d957922a1aec90d0ec852402dc6eca496841ed4. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
cryptolib-upd
branch
from
54e38b6
to
c47a87c
Compare
|
Updated, ready for review and merge. |
cschuchardt88
approved these changes
May 10, 2024
Jim8y
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port protocol-related part of neo-project/neo#3209.
Note, that build and tests are failing because we need to update
neogit submodule. We can merge neo-project/neo#3209 firstly, and then update theneosubmodule onto the fresh master. Then I'll rebase this PR and check that tests are passed.