-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Neo Framework]add IWithdrawable #1056
Conversation
/// <summary> | ||
/// Interface of method that indicate a contract can be withdrawn. | ||
/// </summary> | ||
public interface IWithdrawable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iverificable? Verify is not only for withdraw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for IWithdrawable, not for verify. Just verify happens to be IWithdrawable method.
For the ease of helping developers to implement contract that is withdrawable, not a contract that is verificable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it won't be better if we create IVerify? that it can be used for multiple things, like withdraw GAS and NEO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well yes, but if its purpose is withdrawing, why call it verify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shargon my suggestion is create another pr that create IVerify, then IWithdrawable inherits IVerify, but this pr will still focus on IWithdrawable, cause its name corresponds to INEP11Payable/INEP17Paybel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shargon Go ahead with what you want. But please make sure to have detailed comments for IWithdrawable.
This pr standarize the withdrawable interface and add its comments.