-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write manifest file with storage and payable according the contract needs #129
Conversation
i like the use of attributes |
Maybe we can just use one attribute. |
For storage i can detect the syscall if you prefer |
Neo PR Test ReportRepository: neo-devpack-dotnet Code version / branchNeo-devpack-dotnet: shargon:fix-storage-payable Test Results
Additional infoCode worked as expected. The manifest file was generated correctly.
Test List1. Initial UT 2. Compile Contract using Payable attribute Create a new SmartContract project and add the Payable attribute. Expected result:
2. Compile Contract using HasStorage attribute Create a new SmartContract project and add the HasStorage attribute. Expected result:
2. Compile Contract using both HasStorage and Payable attributes Create a new SmartContract project and add the HasStorage and Payable attributes. Expected result:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested. Thanks!
Close #128