Allow neon to compile from the source

[shargon]

Close #132

• This PR Allow to compile c# and VB scripts from it source

Without arguments

Neo.Compiler.MSIL 2.4.1
2015-2019 The Neo Project

ERROR(S):
  Required option 'f, file' is missing.

  -f, --file          Required. Specify the file to compile to NEF file

  -r, --references    Compilation references

  --help              Display this help screen.

  --version           Display version information.

Compile from source

-f "V:\Temp\sc.cs" -r "Neo.SmartContract.Framework.dll"

Neo.Compiler.MSIL console app v2.4.1.0
Auto Insert entrypoint.
convert succ
gen abi succ
write:sc.nef
write:sc.abi.json
write:sc.manifest.json
SUCC

Compile as usual

-f "V:\Temp\sc.dll"

Neo.Compiler.MSIL console app v2.4.1.0
Auto Insert entrypoint.
convert succ
gen abi succ
write:sc.nef
write:sc.abi.json
write:sc.manifest.json
SUCC

[lock9]

Hi @shargon it is passing UT but the code is not working.
Can we make the Neo.SmartContract.Framework to be automatically referenced?

[lapetina9]

Neo PR Test Report

Repository: neo-devpack-dotnet
Number: 131
Title: Allow neon to compile from the source
Change description: Neon was updated to support *.cs file compilation.

Code version / branch

Neo-devpack-dotnet: shargon:compile-source

Test Results

Test Name	Network	OS	Test Result	Comments
Initial UT		Windows 10 x64	OK
Compile Contract 1 from unit tests		Windows 10 x64	OK
Compile Contract 2 from unit tests		Windows 10 x64	NOK	Conversion errors occurred during compilation. Failed identification of Smart Contract Framework method.

Additional info

We made two tests that should have the same results, but one of them failed to compile the smart-contract. We followed instructions provided in the PR.

Test List

1. Initial UT
Run solution unit tests.

2. Compile Contract 1 from unit tests

The test was to compile the same file that is used in unit tests, using the command line.
Contract code:

namespace Neo.Compiler.MSIL.TestClasses
{
    public class Contract1 : SmartContract.Framework.SmartContract
    {
        //default smartcontract entry point.
        //but the unittest can be init from anywhere
        //no need to add code in Main.
        public static object Main(string method, object[] args)
        {
            return UnitTest_001();
        }
        public static byte[] UnitTest_001()
        {
            var nb = new byte[] { 1, 2, 3, 4 };
            return nb;
        }

    }
}

Expected result:

• File compiled sucessfully.

3. Compile Contract 2 from unit tests
The test was to compile the same file that is used in unit tests, using the command line.
Contract code:

namespace Neo.Compiler.MSIL.TestClasses
{
    public class Contract2 : SmartContract.Framework.SmartContract
    {
        //default smartcontract entry point.
        //but the unittest can be init from anywhere
        //no need to add code in Main.
        public static object Main(string method, object[] args)
        {
            Neo.SmartContract.Framework.Services.Neo.Runtime.Notify(args[0]);
            Neo.SmartContract.Framework.Services.Neo.Runtime.Notify(args[2]);
            return UnitTest_002();
        }
        public static byte UnitTest_002()
        {
            var nb = new byte[] { 1, 2, 3, 4 };
            return nb[2];
        }
    }
}

Expected result:

• File compiled sucessfully.

Actual result:
Compilation failed caused by Neo.SmartContract.Framework not being found.

[shargon]

Can we make the Neo.SmartContract.Framework to be automatically referenced?

If everyone want to, yes, it's easy

[shargon]

but the code is not working.

What doesn't work, could you explain it?

[shargon]

Compilation failed caused by Neo.SmartContract.Framework not being found.

That's the reason of references 😂 You obtain the same behavior in Visual Studio

[lightszero]

I think build from a csproj is more better.

[shargon]

@lock9 could you review it again?

[lock9]

@shargon we are trying to deploy a SC into neo 3 testnet but we are having several issues. I will test this later today

[lock9]

The code is well written and it is very clear. My only suggestion would be to move the content inside that switch to methods.

[lock9]

Hi @shargon, please check shargon#3.
It doesn't work if we reference external dlls but this is totally acceptable.

[erikzhang]

I think "Neo.SmartContract.Framework.dll" should be added as a reference by default. There is no need to add it manually.

[lock9]

Thank you for the changes, this will help a lot to use the compiler. I'm just waiting for the Erik to check if we should use nuget or code references are ok.

[lock9]

It works perfectly. Thanks!