Remove compiler directives #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikzhang
reviewed
Dec 12, 2019
| logger.Log("unsupported instruction " + src.code + "\r\n in: " + to.name + "\r\n"); | ||
| break; | ||
| #else | ||
| throw new Exception("unsupported instruction " + src.code + "\r\n in: " + to.name + "\r\n"); |
There was a problem hiding this comment.
This line should be removed too?
There was a problem hiding this comment.
Maybe the log, but not the exception, isn't it? @lightszero
There was a problem hiding this comment.
@lightszero we should throw the exception or only log it?
There was a problem hiding this comment.
For me, it have sense to stop the conversion if one instruction is unsupported.
There was a problem hiding this comment.
I think should throw for here,skip this could be got more error..
erikzhang
approved these changes
Dec 18, 2019
|
smoke test passed. neo-devpack-dotnet: master dda641a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #143