Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage results #192

Merged
merged 6 commits into from
Mar 2, 2020
Merged

Fix coverage results #192

merged 6 commits into from
Mar 2, 2020

Conversation

shargon
Copy link
Member

@shargon shargon commented Feb 25, 2020

  • Fix wrong coverage calculation, currently added the test folder (+4%)
  • Fix namespaces

Related to the comment of neo-project/neo-vm#279 (comment)

  • Add IfNull UT

Tommo-L
Tommo-L previously approved these changes Feb 28, 2020
vncoelho
vncoelho previously approved these changes Feb 28, 2020
@shargon shargon dismissed stale reviews from vncoelho and Tommo-L via 008f2ca February 29, 2020 09:13
@shargon shargon changed the title Add IfNull UT Fix coverage results Feb 29, 2020
@shargon
Copy link
Member Author

shargon commented Mar 2, 2020

Please, could you review it again @vncoelho ?

@belane belane merged commit adf9425 into master Mar 2, 2020
@belane belane deleted the add-ut branch March 2, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants