Add debug info support #298
Conversation
This file is used by the neo 3 debugger to map NEF file addresses to source code spans to enable source level debugging. It is analogous to the We recently released a Neo 3 preview 2 compatible version of the debugger. That release also includes a version of NEON preview 2 w/ debug info. That version of NEON was built out of my fork of devpack-dotnet since I needed to add the debug info generation in an otherwise preview 2 compatible build. The code in this PR is slightly different which reflects changes in NEON master branch since preview 2. |
| methodJson.SetDictValue("id", method.name); | ||
| methodJson.SetDictValue("name", name); | ||
| methodJson.SetDictValue("range", range); | ||
| methodJson.SetDictValue("params", ConvertParamList(method.paramtypes)); |
There was a problem hiding this comment.
params field does not follow the specification. Either it should be parameters or specification should be updated.
There was a problem hiding this comment.
Thanks for catching this @AnnaShaleva. The specification is correct. I will update the NEON code and I've filed neo-project/neo-debugger#64 to track fixing the neo 3 preview 2 debugger
There was a problem hiding this comment.
FYI, turns out the spec was out of sync w/ the implementation of NEON 2, Neo Smart Contract Debugger for Neo 2 and neo-boa for neo 2. params and return are the correct property names. Sorry for the confusion! Spec update in PR: https://github.com/ngdseattle/design-notes/pull/7
|
@devhawk could you fix the conflicts in order to merge it? |
There was a problem hiding this comment.
The code looks good, my unique concern it's https://github.com/neo-project/neo-devpack-dotnet/pull/298/files#r448785543
Updates neon to support debug info as described in NDX-DN11. There will be a few updates to debug info format for NEO 3 that are
not yet reflected in NDX-DN11published hereFYI, the Neo 3 preview 2 version of this code is in my personal fork: https://github.com/devhawk/neo-devpack-dotnet/tree/devhawk/nefdbgnfo-preview2