Fix: ensure the value in range #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there are other cases that also need to be fixed, expecially checked and unchecked not working for |
|
@shargon please check this out, this is a bug found by @vang1ong7ang |
shargon
previously approved these changes
Dec 11, 2023
|
@shargon all tested, good to go. |
Jim8y
commented
Dec 11, 2023
shargon
reviewed
Dec 11, 2023
…pack-dotnet into fix-unary-expression * 'fix-unary-expression' of github.com:Liaojinghui/neo-devpack-dotnet: Update tests/Neo.Compiler.CSharp.UnitTests/TestClasses/Contract_Inc_Dec.cs Update tests/Neo.Compiler.CSharp.UnitTests/UnitTest_Inc_Dec.cs Update tests/Neo.Compiler.CSharp.UnitTests/UnitTest_Inc_Dec.cs Update src/Neo.Compiler.CSharp/MethodConvert.cs
shargon
reviewed
Dec 15, 2023
tests/Neo.Compiler.CSharp.UnitTests/TestClasses/Contract_Inc_Dec.cs
Outdated
Show resolved
Hide resolved
shargon
approved these changes
Dec 15, 2023
Jim8y
added a commit
to Jim8y/neo-devpack-dotnet
that referenced
this pull request
Dec 15, 2023
…et into storage-get * 'storage-get' of github.com:Liaojinghui/neo-devpack-dotnet: Storage backed properties (neo-project#745) Fix: ensure the value in range (neo-project#828)
Jim8y
added a commit
to Jim8y/neo-devpack-dotnet
that referenced
this pull request
Dec 18, 2023
* master: Update action steps and fixed myget (neo-project#838) add IsEven (neo-project#837) Storage backed properties (neo-project#745) Fix: ensure the value in range (neo-project#828)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the compiler where uint
--can be less than 0:can run forever until oom.