Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch unit test #87

Merged
merged 11 commits into from
Oct 20, 2019
Merged

Switch unit test #87

merged 11 commits into from
Oct 20, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Aug 21, 2019

Test for #86

@shargon shargon mentioned this pull request Aug 21, 2019
Closed
@shargon
Copy link
Member Author

shargon commented Aug 22, 2019

I changed the test for pass, if you want to test it, just uncomment

@shargon shargon requested a review from erikzhang August 27, 2019 15:00
@erikzhang
Copy link
Member

Let's add the support to switch.

vncoelho
vncoelho approved these changes Oct 20, 2019
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations, @shargon!
This will make difference for many people.

@lightszero lightszero merged commit fc0d4e2 into neo-project:master Oct 20, 2019
@shargon shargon deleted the switch-ut branch October 20, 2019 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightszero lightszero lightszero approved these changes

@vncoelho vncoelho vncoelho approved these changes

@erikzhang erikzhang Awaiting requested review from erikzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shargon @erikzhang @lightszero @vncoelho @lock9