[Framework Add] implement payable #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Mar 12, 2024
vncoelho
reviewed
Mar 13, 2024
AnnaShaleva
reviewed
Mar 13, 2024
Comment on lines
172
to
174
| onNEP11PaymentMethod.Parameters[0].Type == ContractParameterType.Hash160 && | ||
| onNEP11PaymentMethod.Parameters[1].Type == ContractParameterType.Integer && | ||
| onNEP11PaymentMethod.Parameters[2].Type == ContractParameterType.Any; |
There was a problem hiding this comment.
Parameter names should also be checked, they are a part of the standard. Take a look at https://github.com/nspcc-dev/neo-go/blob/319880e2014ebbe8abd8ce58dcf212869c22604b/pkg/smartcontract/manifest/standard/comply.go#L68.
There was a problem hiding this comment.
This can be very strict, maybe we want to call to our token myTokenId, I think that names are not needed
There was a problem hiding this comment.
@roman-khimov, what do you think?
There was a problem hiding this comment.
I'm thinking of transfer(to Hash160, from Hash160, amount Integer, id ByteString, _ Any) and Comply() preventing it.
...eo.SmartContract.Framework.UnitTests/TestingArtifacts/Contract_SupportedStandard11Payable.cs
Outdated
Show resolved
Hide resolved
shargon
reviewed
May 21, 2024
shargon
reviewed
May 22, 2024
tests/Neo.SmartContract.Framework.TestContracts/Contract_SupportedStandard11Payable.cs
Outdated
Show resolved
Hide resolved
tests/Neo.SmartContract.Framework.TestContracts/Contract_SupportedStandard17Payable.cs
Outdated
Show resolved
Hide resolved
shargon
previously approved these changes
May 22, 2024
|
Weird, test runs OK on my macos |
vncoelho
reviewed
May 22, 2024
Let's wait for merge the proposal |
shargon
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr focus on implement NEP11 and NEP17 callback standards.
Wait for neo-project/proposals#169