Fix Priority Fee Transactions being treated as Free #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is an issue with Integer rounding making small fee tx behave like free tx. Simply removing p.Size in the ranking constraint will resolve this. Discussed with jseagrave21. Based on Belane's investigation. @erikzhang
|
Transaction fees should be based on the size of the transaction. When sorting, we have to consider the size of the transaction and the amount of the fee. |
f27d
changed the title
Improvement from Belane and Jseagrave21 to first sort by Fee/Size as before and then sort by Fee. This means that if the Fee is > 0 but very small, it will still be prioritised ahead of Free tx.
|
@belane and @jseagrave21 improved on the previous iteration @erikzhang. |
erikzhang
approved these changes
Aug 24, 2018
|
Eagle eyes! I am happy to see such improvements today, really. |
|
Amazing work! |
chenzhitong
referenced
this pull request
in chenzhitong/neo-modules
Oct 13, 2020
ZhangTao1596
added a commit
to ZhangTao1596/neo-modules
that referenced
this pull request
Dec 15, 2020
Initial commit
superboyiii
added a commit
to ZhangTao1596/neo-modules
that referenced
this pull request
Jan 26, 2021
State service more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is an issue with Integer rounding making small fee tx behave like free tx.
Believe this is the cause of priority fee not getting observed.
Simply removing p.Size in the ranking constraint will resolve this. Discussed with jseagrave21.
Based on Belane's investigation.
@erikzhang