Prevent SSRF #692
Merged
Prevent SSRF #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shargon @vang1ong7ang Please check #694 |
vang1ong7ang
reviewed
Mar 2, 2022
| if (entry.IsInternal()) | ||
| return (OracleResponseCode.Forbidden, null); | ||
| } | ||
| goto download; |
There was a problem hiding this comment.
would this result in infinite redirections?
infinite redirections will be stopped by the timeout
There was a problem hiding this comment.
Me can add a max-redirect
There was a problem hiding this comment.
Which timeout stops infinite redirections in the current implementation?
There was a problem hiding this comment.
Which timeout stops infinite redirections in the current implementation?
It seems that no timeout will stop the infinite redirections now.
|
dns rebinding should be also considered |
Closed
Jim8y
reviewed
Mar 3, 2022
erikzhang
approved these changes
Mar 9, 2022
roman-khimov
reviewed
Mar 9, 2022
erikzhang
pushed a commit
that referenced
this pull request
Apr 21, 2022
* add invoked contract (#657) * add in file copyright (#679) * witness rule support (#676) * Prevent SSRF (#692) * limit free gas (#697) * add log when exception happens under debug mode (#690) * dbft: tune MaxBlock* parameters (#688) * Fix StateAPI.MakeFindStatesParams (#699) * update Console to ConsoleHelper (#682) * refac log (#700) * Make RpcServer.ProcessAsync public to enable better neo express integration (#701) * Limit result stack (#696) * fix MaxBlockSystemFee (#703) * code optimise (#704) * Add oracle global timeout (#698)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #693