Limit result stack

src/ApplicationLogs/ApplicationLogs/config.json

@@ -1,7 +1,8 @@
 {
   "PluginConfiguration": {
     "Path": "ApplicationLogs_{0}",
-    "Network": 860833102
+    "Network": 860833102,
+    "MaxStackSize": 65535
   },
   "Dependency": [
     "RpcServer"

src/ApplicationLogs/LogReader.cs

@@ -81,11 +81,11 @@ public static JObject TxLogToJson(Blockchain.ApplicationExecuted appExec)
             trigger["gasconsumed"] = appExec.GasConsumed.ToString();
             try
             {
-                trigger["stack"] = appExec.Stack.Select(q => q.ToJson()).ToArray();
+                trigger["stack"] = appExec.Stack.Select(q => q.ToJson(Settings.Default.MaxStackSize)).ToArray();
             }
-            catch (InvalidOperationException)
+            catch (Exception ex)
             {
-                trigger["stack"] = "error: recursive reference";
+                trigger["exception"] = ex.Message;
             }
             trigger["notifications"] = appExec.Notifications.Select(q =>
             {
@@ -124,11 +124,11 @@ public static JObject BlockLogToJson(Block block, IReadOnlyList<Blockchain.Appli
                     trigger["gasconsumed"] = appExec.GasConsumed.ToString();
                     try
                     {
-                        trigger["stack"] = appExec.Stack.Select(q => q.ToJson()).ToArray();
+                        trigger["stack"] = appExec.Stack.Select(q => q.ToJson(Settings.Default.MaxStackSize)).ToArray();
                     }
-                    catch (InvalidOperationException)
+                    catch (Exception ex)
                     {
-                        trigger["stack"] = "error: recursive reference";
+                        trigger["exception"] = ex.Message;
                     }
                     trigger["notifications"] = appExec.Notifications.Select(q =>
                     {

src/ApplicationLogs/Settings.cs

@@ -16,13 +16,15 @@ internal class Settings
     {
         public string Path { get; }
         public uint Network { get; }
+        public int MaxStackSize { get; }
 
         public static Settings Default { get; private set; }
 
         private Settings(IConfigurationSection section)
         {
             this.Path = section.GetValue("Path", "ApplicationLogs_{0}");
             this.Network = section.GetValue("Network", 5195086u);
+            this.MaxStackSize = section.GetValue("MaxStackSize", (int)ushort.MaxValue);
         }
 
         public static void Load(IConfigurationSection section)

src/RpcServer/RpcServer.Wallet.cs

@@ -389,11 +389,11 @@ private JObject GetVerificationResult(UInt160 scriptHash, ContractParameter[] ar
             json["exception"] = GetExceptionMessage(engine.FaultException);
             try
             {
-                json["stack"] = new JArray(engine.ResultStack.Select(p => p.ToJson()));
+                json["stack"] = new JArray(engine.ResultStack.Select(p => p.ToJson(settings.MaxStackSize)));
             }
-            catch (InvalidOperationException)
+            catch (Exception ex)
             {
-                json["stack"] = "error: recursive reference";
+                json["exception"] = ex.Message;
             }
             return json;
         }

src/RpcServer/RpcServer/config.json

@@ -14,6 +14,7 @@
         "MaxFee": 0.1,
         "MaxConcurrentConnections": 40,
         "MaxIteratorResultItems": 100,
+        "MaxStackSize": 65535,
         "DisabledMethods": [ "openwallet" ]
       }
     ]

src/RpcServer/Settings.cs

@@ -41,6 +41,7 @@ public record RpcServerSettings
         public long MaxGasInvoke { get; init; }
         public long MaxFee { get; init; }
         public int MaxIteratorResultItems { get; init; }
+        public int MaxStackSize { get; init; }
         public string[] DisabledMethods { get; init; }
 
         public static RpcServerSettings Default { get; } = new RpcServerSettings
@@ -53,6 +54,7 @@ public record RpcServerSettings
             MaxFee = (long)new BigDecimal(0.1M, NativeContract.GAS.Decimals).Value,
             TrustedAuthorities = Array.Empty<string>(),
             MaxIteratorResultItems = 100,
+            MaxStackSize = ushort.MaxValue,
             DisabledMethods = Array.Empty<string>(),
             MaxConcurrentConnections = 40,
         };
@@ -70,6 +72,7 @@ public static RpcServerSettings Load(IConfigurationSection section) => new()
             MaxGasInvoke = (long)new BigDecimal(section.GetValue<decimal>("MaxGasInvoke", Default.MaxGasInvoke), NativeContract.GAS.Decimals).Value,
             MaxFee = (long)new BigDecimal(section.GetValue<decimal>("MaxFee", Default.MaxFee), NativeContract.GAS.Decimals).Value,
             MaxIteratorResultItems = section.GetValue("MaxIteratorResultItems", Default.MaxIteratorResultItems),
+            MaxStackSize = section.GetValue("MaxStackSize", Default.MaxStackSize),
             DisabledMethods = section.GetSection("DisabledMethods").GetChildren().Select(p => p.Get<string>()).ToArray(),
             MaxConcurrentConnections = section.GetValue("MaxConcurrentConnections", Default.MaxConcurrentConnections),
         };