-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize oracle log #764
optimize oracle log #764
Conversation
@@ -268,12 +268,14 @@ private async Task SendResponseSignatureAsync(ulong requestId, byte[] txSign, Ke | |||
|
|||
private async Task ProcessRequestAsync(DataCache snapshot, OracleRequest req) | |||
{ | |||
Log($"Process oracle request txid: {req.OriginalTxid}, url: {req.Url}"); | |||
Log($"[{req.OriginalTxid}] Process oracle request start:<{req.Url}>"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
begin and end
start and finish
maybe begin is better
|
||
uint height = NativeContract.Ledger.CurrentIndex(snapshot) + 1; | ||
|
||
(OracleResponseCode code, string data) = await ProcessUrlAsync(req.Url); | ||
|
||
Log($"[{req.OriginalTxid}] Process oracle request end:<{req.Url}>, responseCode:{code}, response:{data}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe finish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the logs, I will soon test it on our examples.
Tested OK. |
No description provided.