Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated .editorconfig & Applied Changes #866

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Updated .editorconfig & Applied Changes #866

merged 1 commit into from
Jan 10, 2024

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jan 9, 2024 •
edited
Loading

  • Updated .editorconfig and run code analyze
  • Added .gitattibutes

Used .editorconfig from neo repo

@superboyiii
Copy link
Member

superboyiii commented Jan 9, 2024 •
edited
Loading

Is this safe that namespace changed after format?
1704795943874

@cschuchardt88
Copy link
Member Author

hmm that's weird!!! 😭

@cschuchardt88
Copy link
Member Author

@superboyiii Must be you. I see no such change.

image

@superboyiii
Copy link
Member

superboyiii commented Jan 9, 2024 •
edited
Loading

Maybe I'm in the wrong way for your editconfig? How should it be applied?
I'm running code analysis on solution.
image

@cschuchardt88
Copy link
Member Author

@superboyiii this is what i ran
image

@superboyiii
Copy link
Member

superboyiii commented Jan 10, 2024 •
edited
Loading

@superboyiii this is what i ran image

Yes, this works when I turned Fix all warnings and errors set in EditorConfig to Fix analyzer warnings and errors set in EditorConfig

@shargon shargon merged commit 99b62d4 into neo-project:master Jan 10, 2024
3 checks passed
@shargon shargon deleted the editorconfig-update branch January 10, 2024 08:09
Jim8y added a commit to Jim8y/neo-modules that referenced this pull request Jan 10, 2024
@Jim8y
Merge branch 'master' of github.com:neo-project/neo-modules
555ba00 
* 'master' of github.com:neo-project/neo-modules:
  Ensure max length (neo-project#845)
  Update .editorconfig and run code analyze (neo-project#866)
  Added AspNetCore (neo-project#863)
  RcpServer: Fixed CORS and Basic Auth (neo-project#812)
  Fix response from getversion due to WS removal (neo-project#859)
  Local dev setup (neo-project#861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@superboyiii superboyiii superboyiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cschuchardt88 @superboyiii @shargon