Fix inconsistency in plugin name

[superboyiii]

Fix inconsistency between Plugin name and Plugin class name. For example: SimplePolicy is using SimplePolicyPlugin as class name, but using SimplePolicy as plugin name. This issue also could be seen on RpcSystemAssetTracker. I think it's also necessary to unify plugin class name on neo3 to avoid this issue.

[shargon]

But the name of the class is used?

[superboyiii]

But the name of the class is used?

Hi, Shargon. What do you mean? Yes the class is used, but uninstall can't be successful if you add this check. I think the best solution is to unify class name to plugin project name. But I'm not sure if it will influence a lot or not.

[shargon]

For reproduce the error, what are the steps?

install plugin RpcSystemAssetTracker uninstall plugin RpcSystemAssetTracker
?

[superboyiii]

For reproduce the error, what are the steps?

install plugin RpcSystemAssetTracker uninstall plugin RpcSystemAssetTracker
?

Yes. Now only SimplePolicy and RpcSystemAssetTracker have this issue.
For example install RpcSystemAssetTracker, uninstall RpcSystemAssetTracker.

[shargon]

Check my last changes, it works for me when is loaded. But the problem is how to remove a used plugin.

[shargon]

mmmm... i see two solutions, as you said.

• 1 Remove plugin.Name, and use the library name for the plugin
  • This avoid create two plugins in the same library
• 2 Use a file like plugins.json for store what plugins are installed.
  • This help when we need to remove hot-plugins (currently used)

[superboyiii]

mmmm... i see two solutions, as you said.

• 1 Remove plugin.Name, and use the library name for the plugin

  • This avoid create two plugins in the same library

• 2 Use a file like plugins.json for store what plugins are installed.

  • This help when we need to remove hot-plugins (currently used)

I think solution 1 makes sense for making plugins more regular.

[vncoelho]

@superboyiii, how is this PR? Should we merge this?
@shargon solution 1 looks more aligned with this PR, right?

[shargon]

1 is good for me

[shargon]

If we want to remove the plugin name, this should be done in neo first

[erikzhang]

@superboyiii Can you test it again?

[superboyiii]

Sure

[superboyiii]

Here's my test steps and result.

1. install Plugins
   
2. Plugins are loaded successfully
   
3. Uninstall plugins
   
4. Plugins are deleted successfully.
   
5. Rename one of the plugin class name, make it different as type name.
   
6. build it and install it
   
7. restart neo-cli and uninstall it.
   
8. Plugin is deleted successfully. Test Pass.
   
9. By the way, Neo v3.0.0-CI00815 isn't compatible as a dependency in neo-plugins, the code of plugins should be adjusted.
   
10. And if neo-cli is using dependency of Neo v3.0.0-CI00815, RpcNep5Tracker and SystemLog will break.
    
    
    Only these are OK.
    

Summary: Test Pass.
Warning: RpcNep5Tracker and SystemLog need adjust if apply the latest neo on neo-cli or neo-plugins.