-
Notifications
You must be signed in to change notification settings - Fork 226
Port neo-gui #488
Port neo-gui #488
Conversation
Ready to review. |
The GUI Forms, are just a copy of |
Yes. But I also removed some obsolete features. No new feature has been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Erik. I don't understand this change. Is this needed? What is going to happen with neo-gui repository?
neo-gui repository will be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, but since testnet is not working, I can't approve this. It is not syncing blocks.
The latest neo master branch is not compatible to the old testnet. (And will never be compatible to it until the new testnet launched.) If you want to test it (and all other PRs), you must test it in a private net built by yourself. |
Is anyone reviewing it? |
I am, give me one day more please |
Hi @erikzhang , I reviewed it already, but it is not possible to properly test because it is not possible to deploy any network. We need to fix this ASAP. The project apparently working, but we can only confirm that by using it with a network. |
Great, I will check that. Thanks |
Co-Authored-By: Shargon <shargon@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The port is done as expected. Some failures in neo-gui already was there.
Co-Authored-By: Shargon <shargon@gmail.com>
I just saw the PR now, @erikzhang. However, this look a good innitiave and nice name for the project. We support neo-node and you did a good choice. |
No description provided.