Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Port neo-gui #488

Merged
merged 21 commits into from
Dec 4, 2019
Merged

Port neo-gui #488

merged 21 commits into from
Dec 4, 2019

Conversation

erikzhang
Copy link
Member

No description provided.

@erikzhang erikzhang marked this pull request as ready for review November 27, 2019 14:25
@erikzhang
Copy link
Member Author

Ready to review.

@shargon
Copy link
Member

shargon commented Nov 27, 2019

The GUI Forms, are just a copy of neo-gui?

@erikzhang
Copy link
Member Author

Yes. But I also removed some obsolete features. No new feature has been added.

Copy link
Contributor

@lock9 lock9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Erik. I don't understand this change. Is this needed? What is going to happen with neo-gui repository?

@erikzhang
Copy link
Member Author

neo-gui repository will be removed.

Copy link
Contributor

@lock9 lock9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but since testnet is not working, I can't approve this. It is not syncing blocks.

neo-gui/neo-gui.csproj Show resolved Hide resolved
@erikzhang
Copy link
Member Author

The latest neo master branch is not compatible to the old testnet. (And will never be compatible to it until the new testnet launched.) If you want to test it (and all other PRs), you must test it in a private net built by yourself.

@erikzhang
Copy link
Member Author

Is anyone reviewing it?

@shargon
Copy link
Member

shargon commented Dec 2, 2019

I am, give me one day more please

@lock9
Copy link
Contributor

lock9 commented Dec 2, 2019

Hi @erikzhang , I reviewed it already, but it is not possible to properly test because it is not possible to deploy any network. We need to fix this ASAP.
According to @belane, the root cause was this PR: neo-project/neo#1249.
I already asked people for a current working configuration, but nobody has it and those who tried to make one (update neo-resilience) informed me that the current code is broken.

The project apparently working, but we can only confirm that by using it with a network.

@erikzhang
Copy link
Member Author

@lock9 We need #491 first.

@lock9
Copy link
Contributor

lock9 commented Dec 2, 2019

Great, I will check that. Thanks

neo-gui/GUI/MainForm.cs Outdated Show resolved Hide resolved
Co-Authored-By: Shargon <shargon@gmail.com>
shargon
shargon previously approved these changes Dec 3, 2019
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port is done as expected. Some failures in neo-gui already was there.

neo-gui/GUI/MainForm.cs Outdated Show resolved Hide resolved
Co-Authored-By: Shargon <shargon@gmail.com>
shargon
shargon previously approved these changes Dec 3, 2019
shargon
shargon previously approved these changes Dec 3, 2019
@vncoelho
Copy link
Member

vncoelho commented Dec 4, 2019

I just saw the PR now, @erikzhang.
I had a filter for neo-gui, since never used it.

However, this look a good innitiave and nice name for the project. We support neo-node and you did a good choice.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants