Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Fix Console.ReadLine in linux #516

Merged
merged 3 commits into from
Dec 15, 2019
Merged

Fix Console.ReadLine in linux #516

merged 3 commits into from
Dec 15, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Dec 11, 2019

Close #503

Please @superboyiii @cloud8little test it

It seems that there is a bug with linux and Console.Read

Bug POC:

Console.ReadLine(); // Show the output
Console.Read();  // Read only one char
Console.ReadLine(); // This doesn't show the output now :S

@shargon shargon changed the title Fix command read in linux Fix Console.ReadLine in linux Dec 11, 2019
@cloud8little
Copy link
Contributor

OK, I will have a test.

@cloud8little
Copy link
Contributor

Test passed.
4751576117739_ pic_hd

cloud8little
cloud8little previously approved these changes Dec 12, 2019
Copy link
Contributor

@cloud8little cloud8little left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this works on linux.

@erikzhang
Copy link
Member

Looks good. But I doubt very much that Console.ReadLine() cannot be used in Linux. I didn't find related issues on Github. I think there must be something wrong with us.

@shargon
Copy link
Member Author

shargon commented Dec 12, 2019

I tried and search and I can't find a solution, after call Read or ReadKey, ReadLine starting to hide the key pressed in linux.

I will try to find the problem and fix it in dotnet source.

belane
belane previously approved these changes Dec 12, 2019
vncoelho
vncoelho previously approved these changes Dec 12, 2019
@shargon
Copy link
Member Author

shargon commented Dec 14, 2019

Wait, I know where is the problem

@shargon shargon dismissed stale reviews from vncoelho and belane via 5aa8dd4 December 14, 2019 19:59
@shargon
Copy link
Member Author

shargon commented Dec 14, 2019

@cloud8little
Copy link
Contributor

@shargon sure.

@erikzhang erikzhang merged commit 689814a into master Dec 15, 2019
@erikzhang erikzhang deleted the fix-console-read branch December 15, 2019 09:23
@cloud8little
Copy link
Contributor

cloud8little commented Dec 16, 2019

@shargon verified and test pass. I just want to know why ctrl+w worked before, and it does not work now.

@shargon
Copy link
Member Author

shargon commented Dec 17, 2019

I just want to know why ctrl+w worked before, and it does not work now.

It works before this PR, or it doesn't works time ago?

@cloud8little
Copy link
Contributor

I just want to know why ctrl+w worked before, and it does not work now.

It works before this PR, or it doesn't works time ago?

Before this PR, yes, ctrl+w worked.

@shargon
Copy link
Member Author

shargon commented Dec 17, 2019

Could you open a issue for this?

Jim8y pushed a commit to Jim8y/neo-node that referenced this pull request Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backspace doesn't work when running neo-cli on linux
5 participants