Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Refactor node commands #536

Merged
merged 94 commits into from Mar 26, 2020
Merged

Refactor node commands #536

merged 94 commits into from Mar 26, 2020

Conversation

shargon
Copy link
Member

@shargon shargon commented Jan 23, 2020

This pull request aims to improve the next things:

  • Reorder the node commands.
  • Ensure that all commands will have help for users.
  • Unify the validation entries around all commands.
  • Provide auto-help.
  • Make easier the creation of new commands for nodes and plugins.
  • Make easier the implementation of autocomplete feature (it will come after merge this).

image

@shargon shargon marked this pull request as ready for review February 10, 2020 09:55
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @shargon!

Copy link

@eryeer eryeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These makes command more clear! Great job Shargon.

@erikzhang
Copy link
Member

Don't forget to modify the workflow so that it can automatically publish Neo.ConsoleService to MyGet.

I think that Neo.ConsoleService may not be modified often, so I plan to publish it directly to NuGet after the PR merges.

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Another level now.

@shargon shargon requested a review from Tommo-L March 19, 2020 10:58
@superboyiii
Copy link
Member

@erikzhang Seems the Git Check stops, could you fix it?

@shargon
Copy link
Member Author

shargon commented Mar 23, 2020

@erikzhang could you merge this PR?

@erikzhang
Copy link
Member

Is it tested?

@shargon
Copy link
Member Author

shargon commented Mar 23, 2020

Is it tested?

Yes, it's tested from my side, we can wait until @superboyiii and @nicolegys approvals.

@superboyiii
Copy link
Member

superboyiii commented Mar 24, 2020

@shargon @erikzhang From my side, it passed our manual test. We're now trying to use automatic test tools to verify it more seriously. Give me three days to get final result. If it's OK, we could merge this into master then maybe release preview2 at the beginning of next week.

@shargon
Copy link
Member Author

shargon commented Mar 24, 2020

@superboyiii take your time

@superboyiii
Copy link
Member

@shargon @erikzhang Test result shows it works well.

@erikzhang erikzhang merged commit 5a46401 into neo-project:master Mar 26, 2020
@shargon shargon deleted the unify-commands branch March 26, 2020 08:58
Qiao-Jin added a commit to Qiao-Jin/neo-node that referenced this pull request Apr 1, 2020
shargon added a commit that referenced this pull request Apr 18, 2020
* Show version in pool

* UpdateChnages

* adapt Dockerfile to recent code changes (#536) (#567)

* Move syscall to native contract

* Start oracle

* Allow start Oracle

* Oracle test

* Show version in pool

* UpdateChnages

* Move syscall to native contract

Co-authored-by: Guil. Sperb Machado <gsm@machados.org>
Jim8y pushed a commit to Jim8y/neo-node that referenced this pull request Aug 18, 2021
* Add commit phase to consensus algorithm (neo-project#534)

* Add commit phase to consensus algorithm

* fix tests

* Prevent repeated sending of `Commit` messages

* RPC call gettransactionheight (neo-project#541)

* getrawtransactionheight

Nowadays two calls are need to get a transaction height, `getrawtransaction` with `verbose` and then use the `blockhash`.
Other option is to use `confirmations`, but it can be misleading.

* Minnor fix

* Shargon's tip

* modified

* Allow to use the wallet inside a RPC plugin (neo-project#536)

* Clean code

* Clean code

* Minor fix on mempoolVerified

* Add MemoryPool Unit tests. Fix bug on initital start of Persisting the Genesis block.

* Prevent `ConsensusService` from receiving messages before starting (neo-project#573)

* Prevent `ConsensusService` from receiving messages before starting

* fixed tests - calling OnStart now

* Consensus recovery log (neo-project#572)

* Pass store to `ConsensusService`

* Implement `ISerializable` in `ConsensusContext`

* Start from recovery log

* Fix unit tests due to constructor taking the store.

* Add unit tests for serializing and deserializing the consensus context.

* Combine `ConsensusContext.ChangeView()` and `ConsensusContext.Reset()`

* Add `PreparationHash` field to `PrepareResponse` to prevent replay attacks from malicious primary (neo-project#576)

* Fixed a problem where `PrepareResponse.PreparationHash` was not assigned.

* Load context from store only when height matches

* Recover nodes requesting ChangeView when possible (neo-project#579)

* Fixes bug in `OnPrepareRequestReceived()`

* Send `RecoveryMessage` only when `message.NewViewNumber <= context.ViewNumber`

* Fix and optimize view changing (#590)

* Allow to ignore the recovery logs

* Add `isRecovering` (neo-project#594)

* Fix accepting own prepare request (neo-project#596)

* Pick some changes from neo-project#575.

* Fixes `Prefixes`

* Restore transactions from saved consensus context (neo-project#598)

* Refactoring

* AggressiveInlining (neo-project#606)

* Reset Block reference when consensus context is initialized after block persist. (neo-project#608)

* Change `ConsensusPayload` for compatibility (neo-project#609)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants