Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add StackItem ToJson #564

Merged
merged 7 commits into from Apr 22, 2020
Merged

Add StackItem ToJson #564

merged 7 commits into from Apr 22, 2020

Conversation

bettybao1209
Copy link
Contributor

@bettybao1209 bettybao1209 commented Apr 14, 2020

@Tommo-L
Copy link
Contributor

Tommo-L commented Apr 14, 2020

For me, it's ok. And if we can move ToJson to vm, it's benifit for neo-cli, rpc module, etc.

@bettybao1209 bettybao1209 changed the title Add StackItem to Json Add StackItem ToJson Apr 15, 2020
@erikzhang
Copy link
Member

Please use neo-project/neo#1569

@erikzhang erikzhang closed this Apr 15, 2020
@Tommo-L
Copy link
Contributor

Tommo-L commented Apr 16, 2020

The same too, neo-project/neo-modules#221 (comment)

@erikzhang erikzhang reopened this Apr 16, 2020
@erikzhang
Copy link
Member

Use Neo.3.0.0-CI00892 directly.

neo-cli/CLI/Helper.cs Outdated Show resolved Hide resolved
@Tommo-L Tommo-L requested a review from erikzhang April 16, 2020 05:47
Copy link
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block until preview2.

@erikzhang erikzhang dismissed their stale review April 22, 2020 03:52

Preview2 has been released.

@erikzhang erikzhang merged commit 8009786 into neo-project:master Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix applicationEngine.Stack.ToJson Contract invoke exceptions for byte[] Concat:
4 participants