Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

3.0.0-preview2 #569

Closed
wants to merge 2 commits into from
Closed

3.0.0-preview2 #569

wants to merge 2 commits into from

Conversation

Tommo-L
Copy link
Contributor

@Tommo-L Tommo-L commented Apr 16, 2020

No description provided.

@@ -19,5 +29,51 @@ public static bool IsYes(this string input)

return input == "yes" || input == "y";
}

public static JObject ToJson(this StackItem item)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't move this to neo it's duplicated in neo-modules, and neo-node

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was fixed in neo-project/neo#1569, but not merged in neo-preview2.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AQtk8ckQwnZTowVgs6zgCZEJyUQyM1z3ew

Copy link
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create release on this branch, but won't merge it to master.

@shargon shargon self-requested a review April 16, 2020 10:04
@Tommo-L
Copy link
Contributor Author

Tommo-L commented Apr 22, 2020

Neo-preview2 has been released.

@Tommo-L Tommo-L closed this Apr 22, 2020
@erikzhang erikzhang deleted the 3.0.0-preview2 branch April 22, 2020 03:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants