This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
dotnet 5.0 #681
Merged
dotnet 5.0 #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update from neo-project
This reverts commit 42d0ef7.
vncoelho
reviewed
Nov 24, 2020
vncoelho
reviewed
Nov 24, 2020
| @@ -7,7 +7,7 @@ COPY NuGet.Config /neo-cli | |||
| WORKDIR /neo-cli | |||
| RUN dotnet restore && dotnet publish -c Release -o /app | |||
|
|
|||
| FROM mcr.microsoft.com/dotnet/core/runtime:3.0 AS Final | |||
| FROM mcr.microsoft.com/dotnet/core/runtime:5.0.0 AS Final | |||
| RUN apt-get update && apt-get install -y \ | |||
There was a problem hiding this comment.
Btw, they updated the namespaces for their docker images. See dotnet/dotnet-docker#2375
The new one should be mcr.microsoft.com/dotnet/runtime:5.0 (or whatever version you want)
snowypowers
reviewed
Nov 25, 2020
Co-authored-by: Yak Jun Xiang <snowypowers+github@gmail.com>
36 tasks
shargon
previously approved these changes
Dec 21, 2020
vncoelho
reviewed
Dec 21, 2020
Directory.Build.props
Outdated
|
|
||
| <PropertyGroup> | ||
| <VersionPrefix>3.0.0</VersionPrefix> | ||
| <VersionSuffix>preview4</VersionSuffix> |
vncoelho
reviewed
Dec 21, 2020
neo-cli/neo-cli.csproj
Outdated
| @@ -1,16 +1,11 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
Change <PackageReference Include="Neo" Version="3.0.0-preview4" /> ?
erikzhang
suggested changes
Dec 22, 2020
erikzhang
approved these changes
Dec 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.