UI for smart contract deployment #44

djnicholson · 2020-01-02T14:43:54Z

Allows any AVM file in the active workspace to be deployed to any Neo Express instance.

Some limitations:

Contracts can't (yet) be deployed to mainnet or testnet (I'll hook that up after Add "Wallet Explorer"; support NEP-6 wallets; support mainnet/testnet transfer/claim #40 is merged)
Contracts deployed this way won't appear in the invocation panel (this needs custom RPC endpoint to get list of deployed contracts neo-express#20 to be resolved, then corresponding changes in neo-visual-tracker)
Storage requirements are currently hardcoded (we can either add checkboxes in the UI, or make compiler changes so this information is in the contract ABI, holding off for now until we decide which approach to follow)
Return type and parameter types are currently hard-coded (these could probably be determined from the ABI)
Metadata (e.g. description, email, author, etc.) are all set to empty strings. This could be left this way, or we could add text fields to the UI, or we could update the compiler to extract this information from attributes in the smart contract source code and add it to the ABI.

devhawk

I compiled TestContract, but the Deploy Contract UI still reads "No compiled contracts (*.avm files) were found in the current workspace." even after I refresh and/or reopen the deploy contract UI

PEBKAC

devhawk · 2020-01-08T19:06:52Z

Metadata (e.g. description, email, author, etc.) are all set to empty strings. This could be left this way, or we could add text fields to the UI, or we could update the compiler to extract this information from attributes in the smart contract source code and add it to the ABI.

This has already been done but you'll need to build NEON yourself in the short term to get it.

devhawk

Originally, I had a build issue that was preventing the panel from displaying correctly. After cleaning my repo and rebuilding both the extension and the test contract, the panel displays correctly but it still can't find the .avm file in the folder

devhawk · 2020-01-08T19:13:30Z

Should we also have a way to right click on an AVM file to initiate deployment (probably do this in a separate task)

djnicholson · 2020-01-08T19:54:51Z

Originally, I had a build issue that was preventing the panel from displaying correctly. After cleaning my repo and rebuilding both the extension and the test contract, the panel displays correctly but it still can't find the .avm file in the folder

From Discord:
devhawkToday at 7:49 PM when I hit refresh in the deploy contracts panel, I get the following in debug console of the extension instance of VSCode: Error parsing contractDetector.ts:21 Object Error: ENOENT: no such file or directory, open '/c:/Users/harry/Source/neo/seattle/visual-devtracker/sample-workspace/TestContract/bin/Debug/netstandard2.0/publish/TestContract.avm' at Object.openSync (fs.js:447:3) at Object.func (electron/js2c/asar.js:138:31) at Object.func [as openSync] (electron/js2c/asar.js:138:31) at Object.readFileSync (fs.js:349:35) at Object.<anonymous> (electron/js2c/asar.js:580:40) at Object.readFileSync (electron/js2c/asar.js:580:40) at new Contract (c:\Users\harry\Source\neo\seattle\visual-devtracker\src\contractDetector.ts:15:36) at c:\Users\harry\Source\neo\seattle\visual-devtracker\src\contractDetector.ts:51:29 at Array.map (<anonymous>) at ContractDetector.<anonymous> (c:\Users\harry\Source\neo\seattle\visual-devtracker\src\contractDetector.ts:51:18) at Generator.next (<anonymous>) at fulfilled (c:\Users\harry\Source\neo\seattle\visual-devtracker\out\contractDetector.js:5:58) looks like a windows specific issue with filepath

devhawk · 2020-01-09T19:29:33Z

Still hitting error finding .avm files on windows. I went in and manually removed the prefix slash from fullpath parameter in Contract constructor and it worked fine.

Error: ENOENT: no such file or directory, open '/c:/Users/harry/Source/neo/seattle/visual-devtracker/sample-workspace/TestContract/bin/Debug/netstandard2.0/publish/TestContract.avm'
    at Object.openSync (fs.js:447:3)
    at Object.func (electron/js2c/asar.js:138:31)
    at Object.func [as openSync] (electron/js2c/asar.js:138:31)
    at Object.readFileSync (fs.js:349:35)
    at Object.<anonymous> (electron/js2c/asar.js:580:40)
    at Object.readFileSync (electron/js2c/asar.js:580:40)
    at new Contract (c:\Users\harry\Source\neo\seattle\visual-devtracker\src\contractDetector.ts:15:36)
    at c:\Users\harry\Source\neo\seattle\visual-devtracker\src\contractDetector.ts:51:29
    at Array.map (<anonymous>)
    at ContractDetector.<anonymous> (c:\Users\harry\Source\neo\seattle\visual-devtracker\src\contractDetector.ts:51:18)
    at Generator.next (<anonymous>)
    at fulfilled (c:\Users\harry\Source\neo\seattle\visual-devtracker\out\contractDetector.js:5:58)

djnicholson · 2020-01-14T15:52:45Z

Still hitting error finding .avm files on windows. I went in and manually removed the prefix slash from fullpath parameter in Contract constructor and it worked fine.

FIxed now. I need to remember to use the fsPath property on Uri objects (instead of path); path works by accident on *nix systems but fsPath is the propery way of getting the corresponding file system path for a file:// URI.

djnicholson · 2020-01-14T15:53:58Z

Originally, I had a build issue that was preventing the panel from displaying correctly. After cleaning my repo and rebuilding both the extension and the test contract, the panel displays correctly

This is a known limitation of the watch script. You need to restart it whenever new panels are added. This is probably Ok because adding a panel is rare, but we can open a separate issue if we want the watch script to be more intelligent.

djnicholson · 2020-01-14T15:54:56Z

Should we also have a way to right click on an AVM file to initiate deployment (probably do this in a separate task)

Opened #56

djnicholson · 2020-01-14T15:57:13Z

Contracts can't (yet) be deployed to mainnet or testnet (I'll hook that up after Add "Wallet Explorer"; support NEP-6 wallets; support mainnet/testnet transfer/claim #40 is merged)

Done

djnicholson · 2020-01-14T15:57:28Z

Contracts deployed this way won't appear in the invocation panel (this needs neo-project/neo-express#20 to be resolved, then corresponding changes in neo-visual-tracker)

Opened #57

djnicholson · 2020-01-14T15:58:34Z

Storage requirements are currently hardcoded (we can either add checkboxes in the UI, or make compiler changes so this information is in the contract ABI, holding off for now until we decide which approach to follow)

Return type and parameter types are currently hard-coded (these could probably be determined from the ABI)

Metadata (e.g. description, email, author, etc.) are all set to empty strings. This could be left this way, or we could add text fields to the UI, or we could update the compiler to extract this information from attributes in the smart contract source code and add it to the ABI.

Opened #58

devhawk · 2020-01-15T06:02:40Z

src/deployPanel.ts

+            //
+            const sb = neon.default.create.scriptBuilder();
+            const script = sb
+                .emitPush(neon.default.u.str2hexstring('')) // description


Contract metadata should be in the abi.json file as of NEON v2.6. If the metadata property is missing, using empty strings is a fine default, but these should be using abi.json if possible

devhawk · 2020-01-15T06:06:33Z

src/deployPanel.ts

+                .emitPush(neon.default.u.str2hexstring('')) // author
+                .emitPush(neon.default.u.str2hexstring('')) // code_version
+                .emitPush(neon.default.u.str2hexstring('')) // name
+                .emitPush(0x01) // storage: {none: 0x00, storage: 0x01, dynamic: 0x02, storage+dynamic:0x03}


storage and dynamic is part of the aformentioned contract metadata. If the metadata property is missing, prompt the user instead of assuming contracts use storage but arent dynamic

devhawk · 2020-01-15T06:07:00Z

src/deployPanel.ts

+                .emitPush(neon.default.u.str2hexstring('')) // code_version
+                .emitPush(neon.default.u.str2hexstring('')) // name
+                .emitPush(0x01) // storage: {none: 0x00, storage: 0x01, dynamic: 0x02, storage+dynamic:0x03}
+                .emitPush('05') // return type - see https://docs.neo.org/docs/en-us/sc/deploy/Parameter.html


This information is in the abi.json file. If the abi.json file is missing, fail deployment rather than assuming return/parameter types

devhawk

Are you planning on reading the abi.json file before completing this PR?

djnicholson · 2020-01-15T11:50:08Z

Are you planning on reading the abi.json file before completing this PR?

After. I've already got issues created for the follow-on items (see above).

devhawk · 2020-01-15T23:02:36Z

Are you planning on reading the abi.json file before completing this PR?
After. I've already got issues created for the follow-on items (see above).

These need to get done before we ship, but totally cool to separate out into multiple tasks

djnicholson added 12 commits December 4, 2019 18:24

watch for *.avm files in the workspace

6b0d6c2

deploy contract command

03379a0

detect changes also

f2d98b6

UI template for deployment dialog

1f2ccce

note to self

8c63a0e

Merge branch 'master' into deploycontract

e82dee2

prepare to support NEP6 wallets

d347b58

remove logging

b705359

extract names and paths from contracts

6a3bf7b

display selected contract details

04701b4

emit deployment tx

4626dd8

Pay GAS, use byte array return type

136bb17

djnicholson requested a review from devhawk January 2, 2020 14:43

djnicholson assigned devhawk Jan 2, 2020

Merge branch 'master' into deploycontract

de5efc2

devhawk previously requested changes Jan 8, 2020

View reviewed changes

devhawk assigned djnicholson and unassigned devhawk Jan 8, 2020

devhawk suggested changes Jan 8, 2020

View reviewed changes

djnicholson added 2 commits January 8, 2020 20:29

Merge branch 'master' into deploycontract

dba2ccd

formatting

64c2e65

djnicholson added 2 commits January 14, 2020 07:12

fix contract detection on Windows

9e3a9bf

support deployment to mainnet/testnet

63b8117

djnicholson mentioned this pull request Jan 14, 2020

Allow contract deployment by right clicking on an AVM file #56

Closed

djnicholson mentioned this pull request Jan 14, 2020

Allow contracts that are deployed through the extension to be invoked through the extension #57

Closed

djnicholson mentioned this pull request Jan 14, 2020

Get additional metadata from ABI when deploying contracts #58

Closed

djnicholson added 2 commits January 14, 2020 16:02

fix whitepsace

944a74b

whitespace

6c64e44

djnicholson requested a review from devhawk January 14, 2020 16:04

djnicholson assigned devhawk and unassigned djnicholson Jan 14, 2020

devhawk reviewed Jan 15, 2020

View reviewed changes

devhawk assigned djnicholson and unassigned devhawk Jan 15, 2020

djnicholson requested a review from devhawk January 15, 2020 11:50

djnicholson assigned devhawk and unassigned djnicholson Jan 15, 2020

devhawk approved these changes Jan 15, 2020

View reviewed changes

Merge branch 'master' into deploycontract

560069e

djnicholson merged commit a0850b6 into master Jan 16, 2020

djnicholson deleted the deploycontract branch January 16, 2020 13:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI for smart contract deployment #44

UI for smart contract deployment #44

djnicholson commented Jan 2, 2020

devhawk left a comment

devhawk commented Jan 8, 2020

devhawk left a comment

devhawk commented Jan 8, 2020

djnicholson commented Jan 8, 2020

devhawk commented Jan 9, 2020

djnicholson commented Jan 14, 2020

djnicholson commented Jan 14, 2020

djnicholson commented Jan 14, 2020

djnicholson commented Jan 14, 2020

djnicholson commented Jan 14, 2020

djnicholson commented Jan 14, 2020

devhawk Jan 15, 2020 •

edited

Loading

devhawk Jan 15, 2020

devhawk Jan 15, 2020

devhawk left a comment

djnicholson commented Jan 15, 2020

devhawk commented Jan 15, 2020

UI for smart contract deployment #44

UI for smart contract deployment #44

Conversation

djnicholson commented Jan 2, 2020

devhawk left a comment

Choose a reason for hiding this comment

devhawk commented Jan 8, 2020

devhawk left a comment

Choose a reason for hiding this comment

devhawk commented Jan 8, 2020

djnicholson commented Jan 8, 2020

devhawk commented Jan 9, 2020

djnicholson commented Jan 14, 2020

djnicholson commented Jan 14, 2020

djnicholson commented Jan 14, 2020

djnicholson commented Jan 14, 2020

djnicholson commented Jan 14, 2020

djnicholson commented Jan 14, 2020

devhawk Jan 15, 2020 • edited Loading

Choose a reason for hiding this comment

devhawk Jan 15, 2020

Choose a reason for hiding this comment

devhawk Jan 15, 2020

Choose a reason for hiding this comment

devhawk left a comment

Choose a reason for hiding this comment

djnicholson commented Jan 15, 2020

devhawk commented Jan 15, 2020

devhawk Jan 15, 2020 •

edited

Loading