This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Expand PUSHBYTES2-PUSHBYTES74 to have human readable names #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the OpCodes PUSHBYTES2 - PUSHBYTES74 are auto generated based on continuous numbering. Because of that they do not have human readable names (e.g. when converting to strings).
This results in:
poorly readable test vectors, e.g:
neo-vm/tests/neo-vm.Tests/Tests/OpCodes/Push/PUSHBYTES10.json
Line 73 in 937c0ff
violation of the (draft) test vector specification ([draft] Test vector specification #94). Therefore adding unnecessary parsing logic for other languages that are also trying to adhere to these test vectors.
The specification reads:
This PR addresses the issues by expanding the instructions.