Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Expand PUSHBYTES2-PUSHBYTES74 to have human readable names #141

Merged
merged 3 commits into from
Apr 28, 2019
Merged

Expand PUSHBYTES2-PUSHBYTES74 to have human readable names #141

merged 3 commits into from
Apr 28, 2019

Conversation

ixje
Copy link
Contributor

@ixje ixje commented Apr 26, 2019

Currently the OpCodes PUSHBYTES2 - PUSHBYTES74 are auto generated based on continuous numbering. Because of that they do not have human readable names (e.g. when converting to strings).

This results in:

This PR addresses the issues by expanding the instructions.

@codecov-io
Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   80.55%   80.55%           
=======================================
  Files          45       45           
  Lines        4587     4587           
=======================================
  Hits         3695     3695           
  Misses        892      892

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 937c0ff...a42aacd. Read the comment docs.

shargon
shargon previously approved these changes Apr 27, 2019
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

igormcoelho
igormcoelho previously approved these changes Apr 27, 2019
Copy link
Contributor

@igormcoelho igormcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good you took the time to do that. I guess this will help more people to easily follow the opcodes logic.

@erikzhang erikzhang dismissed stale reviews from igormcoelho and shargon via ff0f56d April 28, 2019 03:16
@erikzhang erikzhang merged commit 4135d8e into neo-project:master Apr 28, 2019
@ixje ixje deleted the opcode_enum branch April 28, 2019 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants