strict vm shifts (2x)

[igormcoelho]

Reducing limits and adding more tests for shifts.

[codecov-io]

Codecov Report

Merging #167 into master-2.x will not change coverage.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master-2.x     #167   +/-   ##
===========================================
  Coverage       59.03%   59.03%           
===========================================
  Files              17       17           
  Lines            1572     1572           
===========================================
  Hits              928      928           
  Misses            644      644

Impacted Files	Coverage Δ
src/neo-vm/ExecutionEngine.cs	47.51% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15170c4...95d31c7. Read the comment docs.

[shargon]

We can change both variables to short, and we should check if is a breaking change

[igormcoelho]

It's not a breaking change, @vncoelho will make this sure for us ;)
short or int is the same here.

[shargon]

we need to check the storages after this pr

[erikzhang]

Why we need this?

[erikzhang]

static void Main(string[] args)
{
    BigInteger b0 = 1; //1
    BigInteger b1 = b0 << 1; //2
    BigInteger b2 = b1 << -1; //1
}

[erikzhang]

This is BigInteger shift, not int shift.

[erikzhang]

Do not need.

[igormcoelho]

Adding more tests here.

[igormcoelho]

Correct Erik! Sorry for taking your time... some compiler situation tricked me. It converts automatically -1 on shift to 31... took some time to notice it. In other situations it seems to break compiling. I'll open an issue on neo-compiler project.

  EXEC : Convert error : System.Exception: error:System.Numerics.BigInteger Neo.SmartContract.HelloWorld::Main()::IL_0015 Call System.Numerics.BigInteger System.Numerics.BigInteger::op_LeftShift(System.Numerics.BigInteger,System.Int32) ---> System.Exception: unknown call: System.Numerics.BigInteger System.Numerics.BigInteger::op_LeftShift(System.Numerics.BigInteger,System.Int32) [/tmp/NeoContract1/NeoContract1.csproj]
  /tmp/NeoContract1/NeoContract1.csproj(66,5): error MSB3073: The command "./ConvertTask.sh" exited with code -1.