This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 148
Remove Travis and use Github Actions #228
Merged
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
2e56622
Create dotnetcore.yml
erikzhang 04f68a7
dotnet -format
erikzhang 5857a3f
Update dotnetcore.yml
erikzhang 932b357
Update dotnetcore.yml
erikzhang f2a1bc9
Update dotnetcore.yml
erikzhang 8d5bf3e
Update dotnetcore.yml
erikzhang cf45622
Update dotnetcore.yml
erikzhang 17ba878
Merge branch 'master' into github-actions
shargon b6855de
Update dotnetcore.yml
erikzhang 153a90f
Update dotnetcore.yml
erikzhang 987beb0
Update dotnetcore.yml
erikzhang 7e10f06
Update dotnetcore.yml
erikzhang 501d5f8
Update dotnetcore.yml
erikzhang 4b3da64
Remove travis
erikzhang 21269ca
Merge branch 'master' into github-actions
erikzhang fecc572
Update README.md
erikzhang eb43012
Update and rename dotnetcore.yml to test.yml
erikzhang f2b884e
Create dotnetcore.yml
erikzhang 66f2532
Update neo-vm.csproj
erikzhang 6485311
Update and rename dotnetcore.yml to publish.yml
erikzhang e8fe172
Update publish.yml
erikzhang 53b6140
Update publish.yml
erikzhang 32f2417
Update publish.yml
erikzhang d358d7e
Update publish.yml
erikzhang ace92dd
Update test.yml
erikzhang f5f15ff
Delete publish.yml
erikzhang 52683f7
Update and rename test.yml to dotnetcore.yml
erikzhang f9ea888
Update dotnetcore.yml
erikzhang e584761
Update dotnetcore.yml
erikzhang dee001c
Update dotnetcore.yml
erikzhang a7cd6a0
Update dotnetcore.yml
erikzhang 93b44f4
Update dotnetcore.yml
erikzhang 66d717b
Update dotnetcore.yml
erikzhang e129ff7
Update dotnetcore.yml
erikzhang 33d1ea1
Update dotnetcore.yml
erikzhang b8cf0c0
Update dotnetcore.yml
erikzhang 49ba2ef
Update dotnetcore.yml
erikzhang 5baae1d
Update dotnetcore.yml
erikzhang c739887
Update dotnetcore.yml
erikzhang 0e321ca
Update dotnetcore.yml
erikzhang 94b7b1a
Update dotnetcore.yml
erikzhang d0d9a4b
Update dotnetcore.yml
erikzhang 6f97d37
Update dotnetcore.yml
erikzhang File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You really want to use a tool rather than manage this manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to use
--version-suffix
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can tell you from personal experience that managing the version suffix manually will not work out well.
The problem with most versioning schemes is that they are driven by either by date information, by some build system intrinsic (like the number of previous builds executed in a set amount of time) or both. This makes the version number completely non deterministic.
Nerdbank GitVersioning on the other hand produces deterministic version numbers with no dependency on git tags or branches. So building a specific commit locally and on the build server produce the exact same build version. There are also tools to calculate which commit generated a given version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we need an incremental version number. Now I'm using the linux timestamp.
neo-vm/.github/workflows/publish.yml
Line 22 in d358d7e
It generates the package version like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, timestamps are not non deterministic. Nerdbank GitVersioning uses a concept called git height to give each commit it's own deterministic incremental version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm using deterministic version numbers. They are generated by the following command:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devhawk I agree with you that we could use Nerdbank, but I think this may be outside the scope of this PR.