This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Ensure the behavior of Map is deterministic
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Dec 11, 2019
| public TValue Value; | ||
| } | ||
|
|
||
| private class InternalCollection : KeyedCollection<TKey, TItem> |
There was a problem hiding this comment.
I just copied the code from https://github.com/neo-project/neo/blob/master/src/neo/IO/Caching/OrderedDictionary.cs
It is deterministic. We need it in VM.
There was a problem hiding this comment.
I prefer to use SortedDictionary, but we can do benchmark later
There was a problem hiding this comment.
SortedDictionary will sort the keys, which is not needed for us, and there will be additional overhead. We just need to arrange the items in the order they were added.
shargon
approved these changes
Dec 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.