This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Add tests for KEYS, VALUES instructions #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ixje
commented
Mar 19, 2020
| { | ||
| "type": "map", | ||
| "value": { | ||
| "": { |
There was a problem hiding this comment.
fyi; this odd key value ("") is because an Integer stackitem with a 0 value returns an empty byte array instead of a byte array with a single item set to 0, see
neo-vm/src/neo-vm/Types/Integer.cs
Line 16 in 754bca3
It therefore translates to
"" instead of "0x<value>" as all other values do.
shargon
approved these changes
Mar 19, 2020
vncoelho
approved these changes
Mar 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.