Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Add factory to GetState #515

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Add factory to GetState #515

merged 4 commits into from
Nov 6, 2023

Conversation

shargon
Copy link
Member

@shargon shargon commented Nov 6, 2023

Required for neo-project/neo#2942

Jim8y
Jim8y previously approved these changes Nov 6, 2023
@shargon shargon requested a review from Jim8y November 6, 2023 12:15
@shargon shargon merged commit 426e54d into master Nov 6, 2023
2 checks passed
@shargon shargon deleted the state-factory branch November 6, 2023 12:17
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this PR should had been merged when the dependent one is merged as well. The other PR is not yet fully complete.

@vncoelho
Copy link
Member

vncoelho commented Nov 6, 2023

I see that you are using it now neo-project/neo@47317ee

@vncoelho
Copy link
Member

vncoelho commented Nov 6, 2023

In this case, maybe it is better to do this way to already integrate with the NuGet package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants