Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Neo 3 Preview 2 #1467

Closed
devhawk opened this issue Mar 9, 2020 · 10 comments
Closed

Ship Neo 3 Preview 2 #1467

devhawk opened this issue Mar 9, 2020 · 10 comments

Comments

@devhawk
Copy link
Contributor

devhawk commented Mar 9, 2020

As per discussion among core developers, we should focus on shipping the next preview of Neo3 to unblock neo3 developers.

cc @vncoelho @belane to add a list of PRs needed to merge before the preview release

@vncoelho
Copy link
Member

vncoelho commented Mar 9, 2020

neo-project/neo-node#545

@vncoelho
Copy link
Member

vncoelho commented Mar 9, 2020

@shargon, can we merge neo-project/neo-node#536 and implement the other features later?

@superboyiii
Copy link
Member

@vncoelho neo-project/neo-node#545 and neo-project/neo-node#536 both contains checkwitness support, since neo-project/neo-node#536 will be applied on cli, neo-project/neo-node#536 is enough.

@Tommo-L
Copy link
Contributor

Tommo-L commented Mar 10, 2020

I think the following PRs are need.

These are optional

@shargon
Copy link
Member

shargon commented Mar 10, 2020

Agree with @Tommo-L

@belane
Copy link
Member

belane commented Mar 10, 2020

I think these are not really needed, we should keep the minimal changes to publish release. If we wait for changes like "Completion of Storage Payback" it will take much longer.

@Tommo-L
Copy link
Contributor

Tommo-L commented Mar 11, 2020

We need neo-project/neo-node#536, as we need to support cosigner for contract invocation.

@Tommo-L
Copy link
Contributor

Tommo-L commented Mar 17, 2020

Could help tag preview-2 for neo, neo-vm repositories, since they are ready, then we can push the lastest PRs in these repositories.

@devhawk
Copy link
Contributor Author

devhawk commented Apr 6, 2020

FYI, I think neo-modules issue 216 MUST be fixed for preview 2. As far as I can tell, sendRawTransaction is completely broken (though maybe there's a usage pattern that has changed).

@Tommo-L
Copy link
Contributor

Tommo-L commented Apr 26, 2020

Close? as we have released neo3-preview2 successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants