Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing correctness check for dynamic scripts #2820

Closed
roman-khimov opened this issue Sep 28, 2022 · 0 comments · Fixed by #2821
Closed

Missing correctness check for dynamic scripts #2820

roman-khimov opened this issue Sep 28, 2022 · 0 comments · Fixed by #2821

Comments

@roman-khimov
Copy link
Contributor

Describe the bug
We check deployed contracts and transaction scripts for correctness since #2263 and #2266. We can even say that we check all of the code before it's loaded into VM. But now LoadScript from #2756 takes any bytecode for input and creates an execution context with it without any checks.

Expected behavior
Check the script before loading it.
shargon added a commit that referenced this issue Sep 30, 2022
@shargon
Close #2820
c3be0a2
@shargon shargon mentioned this issue Sep 30, 2022
Merged
shargon added a commit that referenced this issue Oct 17, 2022
@shargon
Close #2820 (#2821)
fcbf479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check dynamic scripts neo-project/neo
1 participant
@roman-khimov