Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage access restriction at method level #829

Closed
lock9 opened this issue Jun 14, 2019 · 5 comments
Closed

Add storage access restriction at method level #829

lock9 opened this issue Jun 14, 2019 · 5 comments
Labels
discussion Initial issue state - proposed but not yet accepted

Comments

@lock9
Copy link
Contributor

lock9 commented Jun 14, 2019

Suggestion:
Add additional storage access restriction at method level.

We can potentially increase TPS by running stateless methods concurrently.

Maybe the method could have 3 execution levels:
Stateless
ReadOnly
ReadWrite

I know about the need for the stateless methods (#822), but I'm not very confident if we need ReadOnly and ReadWrite. Maybe we just need Stateless and Stateful types.

@igormcoelho
Copy link
Contributor

By method, you mean CALL, right? Or APPCALL?
The only issue in executing things in parallel is that you need to sync execution at some point...

I mean, you execute ContractA (or MethodA) and now you execute ContractB (or MethodB). When will you stop waiting?

@shargon
Copy link
Member

shargon commented Jun 14, 2019

or in an attribute inside transaction?

@lock9
Copy link
Contributor Author

lock9 commented Jun 17, 2019

We can leave this stateless processing to be done "before or after" the stateful part is done.
Example:
Screen Shot 2019-06-16 at 20 55 37
Screen Shot 2019-06-16 at 20 56 03

We should allow only stateless methods in pre and post-processing stages.

This is not mandatory to NEO 3.0, it can be added later.

@lock9
Copy link
Contributor Author

lock9 commented Aug 11, 2019

Closing this in favor of #919

@lock9 lock9 closed this as completed Aug 11, 2019
@igormcoelho
Copy link
Contributor

I think this is more connected to: #927

Is it different than 927?

Thacryba pushed a commit to simplitech/neo that referenced this issue Feb 17, 2020
Clarify a number of APIs are provided by plugins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Initial issue state - proposed but not yet accepted
Projects
None yet
Development

No branches or pull requests

4 participants