Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Contract - Allow multiplier factor inside policy #895

Closed
lock9 opened this issue Jul 8, 2019 · 11 comments
Closed

Native Contract - Allow multiplier factor inside policy #895

lock9 opened this issue Jul 8, 2019 · 11 comments
Assignees
Labels
discussion Initial issue state - proposed but not yet accepted enhancement Type - Changes that may affect performance, usability or add new features to existing modules. network-policy Module - Issues that affect the network-policy like fees, access list and voting

Comments

@lock9
Copy link
Contributor

lock9 commented Jul 8, 2019

From Shargon:
We should add a multiply factor inside policy native contract (1 by default). This could allow us to reduce the price without make a new release if the price go "to the moon"

@igormcoelho
Copy link
Contributor

I think that all prices should be part of Policy contract... the reason is that, since we will abandon 10GAS fee rule, and all prices are effectively stored on the blockchain too, now all prices may vary as needed. Even small/specific changes are possible now, for example, reducing specific operation costs.
Anyway, the multiplier is a good feature in my opinion, because it's easier to adjust and easy to understand.

@shargon shargon self-assigned this Jul 8, 2019
@erikzhang erikzhang added the discussion Initial issue state - proposed but not yet accepted label Jul 8, 2019
@erikzhang
Copy link
Member

Are you talking about sys_fee or net_fee?

@shargon
Copy link
Member

shargon commented Jul 8, 2019

Both of them and Syscall prices

@erikzhang
Copy link
Member

As I said before, sys_fee are distributed to neo holders. So it is a part of the protocol. Policy is only applied to net_fee. For net_fee, actually feePerByte is a factor.

@shargon
Copy link
Member

shargon commented Jul 8, 2019

And for syscalls?

@igormcoelho
Copy link
Contributor

igormcoelho commented Jul 8, 2019

I think we should do that for sysfees erik. Not necessarialy on Policy contract, like you said, it's focused on network fees, but perhaps a similar structure. Storing individual operation prices there, so that they can be adjusted in time (don't know exactly how yet...). If we dont start like this,it will be complicated to change them in the future... if they are stored somewhere in chain storage, its easy to keep track of prices in time (directly on code its not possible).

@vncoelho
Copy link
Member

vncoelho commented Jul 8, 2019

I think that a multiplier makes sense, but maybe we could have:
sys_fees_X
net_fees_X

It would be a dynamic way for consensus to easily increase net_fees_X during peak times.
But maybe sys_fees_X should be the result of the votes of 50%+ NEO Holders (another voting process :D).

@lock9
Copy link
Contributor Author

lock9 commented Jul 9, 2019

I agree that all fees/prices should be mutable, all of them. We can divide into 2 or 3 issues if you guys think this is good. I think this is a very good feature for neo 3

@igormcoelho
Copy link
Contributor

igormcoelho commented Jul 12, 2019

We should perhaps re-open this in a different format... Erik is right, Policy only applies to network policy (including network fees).

In this case, we would need to propose a contract, perhaps a governance contract, that controls voting and also system fee prices.

@lock9
Copy link
Contributor Author

lock9 commented Aug 10, 2019

@neo-project/core should we close this? I didn't quite understand if this is implemented already or not.

@lock9 lock9 added enhancement Type - Changes that may affect performance, usability or add new features to existing modules. network-policy Module - Issues that affect the network-policy like fees, access list and voting labels Aug 10, 2019
@shargon
Copy link
Member

shargon commented Aug 11, 2019

I think that is a low-priority issue, we can implement this in the future, but is good to be able to change the fee, or adjust the price one time per year, or every 6 months

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Initial issue state - proposed but not yet accepted enhancement Type - Changes that may affect performance, usability or add new features to existing modules. network-policy Module - Issues that affect the network-policy like fees, access list and voting
Projects
None yet
Development

No branches or pull requests

5 participants