-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In NEO 3, have at least one consensus node using NeoPT (C++ VM) #976
Comments
Do we have a complete c++ node? 1- We need to test first in testnet the future implementations Very distant future for me |
It's very easy to use a C++ VM on existing python (or perhaps go) implementations of Neo, but the VM is just a small part of the project @lock9 . |
But one thing I agree with you @lock9, if someone manages to package a complete node for consensus (perhaps Python), and if it uses C++ VM, then surely we will be able to keep it updated much faster. I don't think it's much work to do on the VM side, as C++ VM is a complete mimic of C# one, and changes are not very common on VM. |
We don't need a full node in c++, just the VM. |
Not far, I would say 95% complete (1 day work). Major decision missing is how to handle smart pointers on stack efficiently... and the reason I haven't decided it yet, it's related to an open discussion on neo-vm regarding the possible abolishion of Struct vmtype... as soon as this is decided, I can move on with the best possible structure. Depending on the result, I will have to use other pointer structure on C++ (tricky situation ;) ) |
Can we close this @lock9? I think this doesn't relate to core development.. any alternative group can propose C++/Go/Python/Rust implementations independently, and run nodes when it's ready. |
Sorry @igormcoelho, the thing here is that we need to have this version officially supported by our C# code. It won't matter if we have a c++ vm if it is not used in a C# version (consensus). Communities are working in relay nodes, there is no security increase in having multiple VM implementations (at this stage). All that can happen is they wrongly confirm or deny a transaction, and you can imagine the problems caused by confirming an invalid transaction. Please, do not close this. I've been messaged several times about this issue. This is of great importance for multiple people and projects. |
NeoVM++ is already there for communities to help improve and use: https://github.com/neoresearch/nvmpp |
* update cli * update English * update rpc
To have a more diversified environment, I suggest we use a C++ in at least one of the consensus nodes (while we have this option).
This will also encourage communities to use this VM, if they know that its being 'maintained'.
I consider this a subject of high importance, although this is something we can do in the 'distant future'.
What is your opinion @neo-project/core ?
The text was updated successfully, but these errors were encountered: