Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues templates for Bug report and Feature Request #1034

Merged
merged 27 commits into from Sep 1, 2019

Conversation

@lock9
Copy link
Contributor

commented Aug 16, 2019

lock9 added 5 commits Aug 14, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Aug 16, 2019

Codecov Report

Merging #1034 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1034   +/-   ##
=======================================
  Coverage   61.29%   61.29%           
=======================================
  Files         196      196           
  Lines       13428    13428           
=======================================
  Hits         8231     8231           
  Misses       5197     5197

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d1d6a...ed2c7d0. Read the comment docs.

lock9 added 3 commits Aug 16, 2019
@vncoelho
Copy link
Member

left a comment

Good idea and templates, @lock9.
There are some minor comments.

vncoelho and others added 2 commits Aug 16, 2019
@shargon

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Is good to me, is finished @lock9 ?

@lock9 lock9 requested review from vncoelho, shargon and erikzhang Aug 20, 2019

@lock9 lock9 referenced this pull request Aug 20, 2019
vncoelho and others added 5 commits Aug 24, 2019
@shargon

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Ready to merge?

shargon added 2 commits Aug 27, 2019
@lock9

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

@neo-project/core I need 1 more approval to merge this, can any of you check it please?

@vncoelho

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

@lock9, some minor adjustments were pushed. Please take a look.

lock9 added 2 commits Aug 30, 2019

@lock9 lock9 merged commit 2da4fb1 into neo-project:master Sep 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.