Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify exceptions from #1254 #1292

Closed
wants to merge 1 commit into from
Closed

Unify exceptions from #1254 #1292

wants to merge 1 commit into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Nov 27, 2019

My review of #1254 (review)

erikzhang
erikzhang requested changes Nov 27, 2019
View reviewed changes
Copy link
Member

@erikzhang erikzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exceptions should not be unified. We should use the correct exceptions.

@shargon
Copy link
Member Author

shargon commented Nov 27, 2019

But we have 3 different for the same check

@shargon shargon closed this Nov 27, 2019
@shargon shargon deleted the unify-exceptions branch November 27, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang erikzhang requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shargon @erikzhang