-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SALT to db3 wallet #1396
Add SALT to db3 wallet #1396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds a good idea, @shargon. Some salt, pepper, saffron, etc..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shargon, perhaps this could be optional. What do you think?
I mean, it could even be the default.
However, the option without salt may be of interest of some people.
I think that should be like this by default. In what scenario are you thinking about? |
I think we can store NEP-2 encrypted keys into db3. |
I will try |
It could be very slow if we have a lot of address encrypted with scrypt |
Made some tests on this PR
Rpc:
These are based on my local environment which I have already merged this PR into latest master branch. All tests passed. It works well and compatibly. |
Time to merge? |
I think it is important to use NEP-2 in wallets. We can adjust the settings of SCRYPT to make it be faster. |
Then we will reduce the security of these wallets. |
In the worst case, it is as secure as it is today. |
Closed in favor of #1444 |
Close #1395