Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SALT to db3 wallet #1396

Closed
wants to merge 7 commits into from
Closed

Add SALT to db3 wallet #1396

wants to merge 7 commits into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Jan 3, 2020

Close #1395

@shargon shargon requested a review from erikzhang January 3, 2020 09:57
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds a good idea, @shargon. Some salt, pepper, saffron, etc..

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shargon, perhaps this could be optional. What do you think?

I mean, it could even be the default.
However, the option without salt may be of interest of some people.

@shargon
Copy link
Member Author

shargon commented Jan 3, 2020

I think that should be like this by default. In what scenario are you thinking about?

@erikzhang
Copy link
Member

I think we can store NEP-2 encrypted keys into db3.

@shargon
Copy link
Member Author

shargon commented Jan 7, 2020

I think we can store NEP-2 encrypted keys into db3.

I will try

@shargon
Copy link
Member Author

shargon commented Jan 7, 2020

I think we can store NEP-2 encrypted keys into db3.

It could be very slow if we have a lot of address encrypted with scrypt

@superboyiii
Copy link
Member

superboyiii commented Jan 13, 2020

Made some tests on this PR
Node:

  1. Build and publish neo-cli with reference on neo.
  2. Create both json and db3 wallet.
  3. Import & export key.
  4. Start consensus, make transactions.

Rpc:

  1. Invoke openwallet to open wallet by PRC.
  2. Invoke listaddress to watch address in wallet.
  3. Invoke sendfrom to make transaction.
  4. Invoke RpcNep5Tracker for balance and transaction history.

These are based on my local environment which I have already merged this PR into latest master branch.

All tests passed. It works well and compatibly.

@shargon
Copy link
Member Author

shargon commented Feb 1, 2020

Time to merge?

@erikzhang
Copy link
Member

I think it is important to use NEP-2 in wallets. We can adjust the settings of SCRYPT to make it be faster.

@shargon
Copy link
Member Author

shargon commented Feb 5, 2020

We can adjust the settings of SCRYPT to make it be faster.

Then we will reduce the security of these wallets.

@erikzhang
Copy link
Member

In the worst case, it is as secure as it is today.

@shargon
Copy link
Member Author

shargon commented Feb 17, 2020

Closed in favor of #1444

@shargon shargon closed this Feb 17, 2020
@shargon shargon deleted the db3-salt branch February 17, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SALT to DB3 wallets
5 participants