Oracle policy contract #1445

doubiliu · 2020-02-13T10:29:52Z

Oracle Policy Contract
Contains the following features:
1.Delegate a third party to become an Oracle node.
2.Get current Oracle node list.
3.Get the current number of Oracle nodes.
4.Set / read timeout.
5.Set / read but per-request fees

Close #1277

src/neo/Oracle/OraclePolicyContract.cs

src/neo/neo.csproj

src/neo/Oracle/OraclePolicyContract.cs

src/neo/neo.csproj

src/neo/Oracle/OraclePolicyContract.cs

belane · 2020-02-17T13:17:06Z

Good job @doubiliu. Please, can you better move the pull request to the oracles branch? I just regenerated it, (https://github.com/neo-project/neo/tree/oracles).

src/neo/Oracle/OraclePolicyContract.cs

src/neo/SmartContract/Native/Oracle/OracleContract.cs

src/neo/SmartContract/Native/Tokens/NeoToken.cs

Tommo-L · 2020-02-27T11:18:38Z

src/neo/SmartContract/Native/Tokens/NeoToken.cs

+            if (storage_count is null)
+            {
+                ECPoint[] validators = new ECPoint[Blockchain.StandbyValidators.Length];
+                System.Array.Copy(Blockchain.StandbyValidators, validators, validators.Length);


It's not safe here, I've added a temporary array to prevent the data from being tampered outside.

Could you create another PR in master, because oracle will spend more time in be merged

Okay, PR #1458. I'll reset it. But ut will fail.

belane · 2020-03-01T12:18:15Z

We discussed that also during community assembly with NEOFS.
@belane, could you help to clarify this?

I'm sorry @vncoelho but the option of open oracles was ruled out in #1278.
We can study the possibility of including it in the future once the current implementation is stable, as it is definitely a very interesting option.

src/neo/SmartContract/Native/Oracle/OracleContract.cs

shargon

Only this doubt. But I think that we can advance.

src/neo/SmartContract/Native/Oracle/OracleContract.cs

Co-Authored-By: Erik Zhang <erik@neo.org>

erikzhang · 2020-03-03T07:38:16Z

src/neo/SmartContract/Native/Oracle/OracleContract.cs

+        /// <param name="args">Parameter Array</param>
+        /// <returns>Returns true if the execution is successful, otherwise returns false</returns>
+        [ContractMethod(0_03000000, ContractParameterType.Boolean, ParameterTypes = new[] { ContractParameterType.Integer }, ParameterNames = new[] { "httpConfig" })]
+        private StackItem SetHttpConfig(ApplicationEngine engine, Array args)


If we have multiple settings in HttpConfig, do we have to set all of them at once?

Yes, but if you have other ideas, I can change

Maybe we can get or set it by key. For example:

GetConfig("HttpTimeout");

SetConfig("HttpTimeout", 2000);

@shargon What's your opinion?

Use this way?

SetHttpConfig("Timeout", 2000) // put: http+timeout => 2000 GetHttpConfig() // return all the http configurations

If we use enum or const for the name, it's good for me :)

shargon · 2020-03-04T20:54:27Z

src/neo/SmartContract/Native/Oracle/OracleContract.cs

@@ -31,9 +32,9 @@ public OracleContract()
        internal override bool Initialize(ApplicationEngine engine)
        {
            if (!base.Initialize(engine)) return false;
-            engine.Snapshot.Storages.Add(CreateStorageKey(Prefix_HttpConfig), new StorageItem
+            engine.Snapshot.Storages.Add(CreateStorageKey(Prefix_HttpConfig, Encoding.UTF8.GetBytes("Timeout")), new StorageItem


src/neo/SmartContract/Native/Oracle/OracleContract.cs

Tommo-L · 2020-03-11T05:33:30Z

@shargon @erikzhang Could we speed up the progress of Oracle? Now that the scheme has been determined, there are still two PRs(Oracle Transaction Attributes + Filter) to be delivered.

If it is delivered early, we can test the whole Oracle and show it at the next Neo conference. If possible, could you @shargon send the rest PRs, plz.

shargon · 2020-03-11T08:05:10Z

I will merge it because oracle branch should improve this speed, any review can be done later in this branch

* first commit * format * Simplify code * add UT and add some feature * Fix bug * Add summary and fix bug * format * format * little change * little change * little change * change Fee & Fix bug * Optimize * add config class * FiX UT * Format * Fix UT * Fix format and Optimize * Add some UT * Fix bug and add UT * Update src/neo/SmartContract/Native/Oracle/OraclePolicyContract.cs Co-Authored-By: Luchuan <luchuan@ngd.neo.org> * little change * format * Update src/neo/SmartContract/Native/Oracle/OraclePolicyContract.cs Co-Authored-By: Shargon <shargon@gmail.com> * add check * change validator * Add double initialization check * add UT * Add UT * change UT * fill UT * up ut and fix NeoToken.GetValidators * remove console * reset NEO.getValidators * fix GetOracleValidators * Rename variable * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-Authored-By: Erik Zhang <erik@neo.org> * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-Authored-By: Erik Zhang <erik@neo.org> * Fix bug * change logic * Fix name * change to const * Add double initialization check and fix ut * optimize Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Luchuan <luchuan@ngd.neo.org> Co-authored-by: Luchuan <luchuan@neo.org> Co-authored-by: Erik Zhang <erik@neo.org>

* first commit * format * Simplify code * add UT and add some feature * Fix bug * Add summary and fix bug * format * format * little change * little change * little change * change Fee & Fix bug * Optimize * add config class * FiX UT * Format * Fix UT * Fix format and Optimize * Add some UT * Fix bug and add UT * Update src/neo/SmartContract/Native/Oracle/OraclePolicyContract.cs Co-Authored-By: Luchuan <luchuan@ngd.neo.org> * little change * format * Update src/neo/SmartContract/Native/Oracle/OraclePolicyContract.cs Co-Authored-By: Shargon <shargon@gmail.com> * add check * change validator * Add double initialization check * add UT * Add UT * change UT * fill UT * up ut and fix NeoToken.GetValidators * remove console * reset NEO.getValidators * fix GetOracleValidators * Rename variable * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-Authored-By: Erik Zhang <erik@neo.org> * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-Authored-By: Erik Zhang <erik@neo.org> * Fix bug * change logic * Fix name * change to const * Add double initialization check and fix ut * optimize Co-authored-by: Shargon <shargon@gmail.com> Co-authored-by: Luchuan <luchuan@ngd.neo.org> Co-authored-by: Luchuan <luchuan@neo.org> Co-authored-by: Erik Zhang <erik@neo.org> Oracle Syscall (#1399) * Plugins from List to array * Move false to init * Fix UT * Refactor * UT * Change HTTP to HTTPS * UT Syscall * Remove Version * Remove HTTP from the syscall name * Check schema * Rename * Update src/neo/Oracle/OracleRequest.cs Co-Authored-By: Erik Zhang <erik@neo.org> * Fix abstract * Rename * Remove Body * Change order of members * Rename Neo.Oracle.Get Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com> Co-authored-by: erikzhang <erik@neo.org> Co-authored-by: Belane <srbelane@gmail.com> Oracle Syscall (#1399) * Plugins from List to array * Move false to init * Fix UT * Refactor * UT * Change HTTP to HTTPS * UT Syscall * Remove Version * Remove HTTP from the syscall name * Check schema * Rename * Update src/neo/Oracle/OracleRequest.cs Co-Authored-By: Erik Zhang <erik@neo.org> * Fix abstract * Rename * Remove Body * Change order of members * Rename Neo.Oracle.Get Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com> Co-authored-by: erikzhang <erik@neo.org> Co-authored-by: Belane <srbelane@gmail.com> Rename OracleResult->OracleResponse (#1516) Removed hash from the response Oracle Syscall (#1399) * Plugins from List to array * Move false to init * Fix UT * Refactor * UT * Change HTTP to HTTPS * UT Syscall * Remove Version * Remove HTTP from the syscall name * Check schema * Rename * Update src/neo/Oracle/OracleRequest.cs Co-Authored-By: Erik Zhang <erik@neo.org> * Fix abstract * Rename * Remove Body * Change order of members * Rename Neo.Oracle.Get Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com> Co-authored-by: erikzhang <erik@neo.org> Co-authored-by: Belane <srbelane@gmail.com> Rename OracleResult->OracleResponse (#1516) Removed hash from the response Oracle Service (#1517) * Oracle Service * Fix fee * Optimize load configuration * Fix akka message * Optimize * dotnet format * Fix sort * Oracle Service * Fix fee * Optimize load configuration * Fix akka message * Optimize * dotnet format * Fix sort * Apply rename * Small changes * Add UT * Fix Start Stop * dotnet-format * Migrate to HTTPS test * Change AKKA message * Tommo recomendations * Add comunication between OracleTx and UserTx * Advance of signature * Fix UT * dotnet-format * Advance of signature Fix UT dotnet-format * Fix UT * Remove duplica method * Reduce timeout time * Add log for fix UT * Add filters * Change port to 443 * Oracle Service * Fix fee * Optimize load configuration * Fix akka message * Optimize * dotnet format * Fix sort * Oracle Service * Fix fee * Optimize load configuration * Fix akka message * Optimize * dotnet format * Fix sort * Apply rename * Small changes * Add UT * Fix Start Stop * dotnet-format * Migrate to HTTPS test * Change AKKA message * Tommo recomendations * Add comunication between OracleTx and UserTx * Advance of signature * Fix UT * dotnet-format * Fix UT * Remove duplica method * Reduce timeout time * Add log for fix UT * Add filters * Change port to 443 * Merge changes * Change SSL Protocol * Merge remote-tracking branch 'neo-project/oracle-service' into oracle-service * Add UT certificate * Clean code * Add UT fix GetOracleMultiSigAddress (#1538) * fix GetOracleMultiSigAddress * First lowercase Co-authored-by: Shargon <shargon@gmail.com> Oracle: Tx comunication (#1540) * Tx comunication * Some fixes Transaction Version (#1539) Oracle: Allow wallets to add assert for the oracle response (#1541) * Add assert for each oracle request * Change to goto * Improve wallet asserts * Optimize * Fix URL type * dotnet format * Oracle: Tx comunication (#1540) * Tx comunication * Some fixes * Optimize OracleExecutionCache * Add assert for each oracle request * Change to goto * Improve wallet asserts * Optimize * Fix URL type * dotnet format * Optimize OracleExecutionCache * MakeTransaction UT Oracle: Set the right Tx version (#1542) * Set the right Tx version * Remove Error types from TX and VM * Neo.Oracle.Get now only return the result or null Oracle: P2P Response Signature Message (#1553) * Oracle Response Signature P2P * caches * rename private fields * remove comments * remove more comments and fix size * Clean code Co-authored-by: Shargon <shargon@gmail.com> Oracle: OracleService (#1555) * Start pool * Prepare for neo-node * Fix double call * Prepare pool * Fix * Join oracle pool with oracle service * dotnet-format * Try to fix UT * UT pass * Fix UT * Fix p2p message * Unify collections * Relay p2p message * Clean code and fixes * Send tx to OracleService * RequestTx will wait for ResponseTx * Rename * Remove supervisor * Allow to put request, and response in the same block * Check the sender of OracleResponses * Remove OracleResponse message in OracleService * Organize code * Fix typo * Remove task count TODO * Remove Thread-safe TODO * Remove TODO * ResponseItem changes * Read the oracle contract on my response Receive oraclePayload * Clean code * Add Stop message * Save only one response for PublicKey/RequestTx Improve sorting response pool * Improve sort * Group sort methods in the same region * Ask for the request TX if I don't have it * Reorder code * Rename * First oracle TX Oracle: Remove some TODOs (#1574) * Remove some todos * Remove one method * Reuse ManualWitness * dotnet format * Allow both tx in the same block without change order or fee * Fix p2p message serialization * Fix p2p * Fixes and IInventory * Fix akka message * Fix ut Fix conflicts Remove double call

doubiliu added 3 commits February 13, 2020 18:08

first commit

074fc9a

Merge remote-tracking branch 'upstream/master' into OraclePolicyContract

d173f4c

format

25b82cd

Tommo-L reviewed Feb 13, 2020

View reviewed changes

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

src/neo/neo.csproj Outdated Show resolved Hide resolved

Tommo-L reviewed Feb 14, 2020

View reviewed changes

Simplify code

04fdf94

Tommo-L reviewed Feb 14, 2020

View reviewed changes

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

Tommo-L reviewed Feb 14, 2020

View reviewed changes

src/neo/neo.csproj Show resolved Hide resolved

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

add UT and add some feature

e4dc1ac

Tommo-L reviewed Feb 15, 2020

View reviewed changes

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

Fix bug

80bc65f

Tommo-L reviewed Feb 15, 2020

View reviewed changes

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

Add summary and fix bug

aadf197

Tommo-L reviewed Feb 16, 2020

View reviewed changes

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

format

748a3af

Tommo-L reviewed Feb 17, 2020

View reviewed changes

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

format

3c40655

Tommo-L reviewed Feb 17, 2020

View reviewed changes

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

doubiliu added 3 commits February 17, 2020 10:51

little change

6bf9c86

little change

6e3369a

little change

846d195

doubiliu marked this pull request as ready for review February 17, 2020 03:12

Tommo-L previously approved these changes Feb 17, 2020

View reviewed changes

doubiliu requested review from erikzhang, belane and vncoelho February 17, 2020 04:02

shargon reviewed Feb 17, 2020

View reviewed changes

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

belane reviewed Feb 17, 2020

View reviewed changes

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

src/neo/Oracle/OraclePolicyContract.cs Outdated Show resolved Hide resolved

shargon reviewed Feb 27, 2020

View reviewed changes

src/neo/SmartContract/Native/Oracle/OracleContract.cs Outdated Show resolved Hide resolved

src/neo/SmartContract/Native/Tokens/NeoToken.cs Outdated Show resolved Hide resolved

remove console

d042560

Tommo-L reviewed Feb 27, 2020

View reviewed changes

reset NEO.getValidators

704051a

Luchuan and others added 2 commits March 2, 2020 18:51

fix GetOracleValidators

953a288

Rename variable

aad74d9

shargon reviewed Mar 2, 2020

View reviewed changes

src/neo/SmartContract/Native/Oracle/OracleContract.cs Show resolved Hide resolved

shargon approved these changes Mar 2, 2020

View reviewed changes

erikzhang reviewed Mar 3, 2020

View reviewed changes

src/neo/SmartContract/Native/Oracle/OracleContract.cs Outdated Show resolved Hide resolved

src/neo/SmartContract/Native/Oracle/OracleContract.cs Outdated Show resolved Hide resolved

doubiliu and others added 3 commits March 3, 2020 01:16

Update src/neo/SmartContract/Native/Oracle/OracleContract.cs

0c0f9e3

Co-Authored-By: Erik Zhang <erik@neo.org>

Update src/neo/SmartContract/Native/Oracle/OracleContract.cs

8876540

Co-Authored-By: Erik Zhang <erik@neo.org>

Fix bug

2a41962

erikzhang reviewed Mar 3, 2020

View reviewed changes

doubiliu added 2 commits March 4, 2020 14:18

change logic

e6bb7b9

Fix name

66aea1f

shargon reviewed Mar 4, 2020

View reviewed changes

change to const

19447cd

shargon reviewed Mar 5, 2020

View reviewed changes

src/neo/SmartContract/Native/Oracle/OracleContract.cs Show resolved Hide resolved

Luchuan added 2 commits March 11, 2020 13:17

Add double initialization check and fix ut

7e64f2c

optimize

65b823b

shargon merged commit e3f6b03 into neo-project:oracles Mar 11, 2020

shargon deleted the OraclePolicyContract branch March 11, 2020 08:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Oracle policy contract #1445

Oracle policy contract #1445

doubiliu commented Feb 13, 2020 •

edited

Loading

belane commented Feb 17, 2020

Tommo-L Feb 27, 2020 •

edited

Loading

shargon Feb 28, 2020

Tommo-L Feb 28, 2020 •

edited

Loading

belane commented Mar 1, 2020

shargon left a comment

erikzhang Mar 3, 2020

doubiliu Mar 3, 2020

erikzhang Mar 3, 2020

doubiliu Mar 3, 2020

Tommo-L Mar 3, 2020

shargon Mar 3, 2020

shargon Mar 4, 2020

Tommo-L commented Mar 11, 2020 •

edited

Loading

shargon commented Mar 11, 2020

Oracle policy contract #1445

Oracle policy contract #1445

Conversation

doubiliu commented Feb 13, 2020 • edited Loading

belane commented Feb 17, 2020

Tommo-L Feb 27, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tommo-L Feb 28, 2020 • edited Loading

Choose a reason for hiding this comment

belane commented Mar 1, 2020

shargon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tommo-L commented Mar 11, 2020 • edited Loading

shargon commented Mar 11, 2020

doubiliu commented Feb 13, 2020 •

edited

Loading

Tommo-L Feb 27, 2020 •

edited

Loading

Tommo-L Feb 28, 2020 •

edited

Loading

Tommo-L commented Mar 11, 2020 •

edited

Loading