Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TransactionInvocation.GetScript to StateReader #170

Merged
merged 3 commits into from
Feb 8, 2018

Conversation

RavenXce
Copy link
Contributor

@RavenXce RavenXce commented Feb 7, 2018

This allows smart contracts to check that the transaction is
an invocation to the same contract during verification phase.

Example use case: neo-project/proposals#18 (comment)

This allows smart contracts to check that the transaction is
an invocation to the same contract during verification phase.

Example use case: neo-project/proposals#18 (comment)
@@ -104,6 +104,8 @@ public StateReader()
Register("Neo.Transaction.GetOutputs", Transaction_GetOutputs);
Register("Neo.Transaction.GetReferences", Transaction_GetReferences);
Register("Neo.Transaction.GetUnspentCoins", Transaction_GetUnspentCoins);
Register("Neo.Transaction.GetUnspentCoins", Transaction_GetUnspentCoins);
Register("Neo.InvocationTransaction.GetScript", InvocationTransaction_GetScript);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be Register("Neo.Transaction.GetScript", Transaction_GetScript)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, only the subclass InvocationTransaction has the Script property. can we still just use Transaction?

@erikzhang erikzhang merged commit f49f266 into neo-project:master Feb 8, 2018
@dbucci24
Copy link

@erikzhang
I would like to collaborate in the Spanish translation, is it done?

@jonatanblockchain
Copy link

@dbucci24 no, quedan partes por traducir y mejorar.
Por ejemplo, la parte de python: http://docs.neo.org/en-us/sc/getting-started-python.html

Si quieres contacta conmigo en discord nick 'jonatan' y unimos fuerzas.

@dbucci24
Copy link

@jonatanblockchain ahi te escribi en discord, pero no estoy seguro si eres tu, hay varios 'jonatan' :p

@jonatanblockchain
Copy link

tengo el mismo avatar!

@dbucci24
Copy link

@jonatanblockchain no te encuentro!! agregame: DavidB24

@jonatanblockchain
Copy link

yo tampoco, si estas en el discord de NEO, en el canal csharp, deberias ver un mensaje mio.

@dbucci24
Copy link

no estoy en el grupo, mi tag para encontrarme es #9227, sino pasame el tuyo :)

@dbucci24
Copy link

@jonatanblockchain me podrías decir en que carpeta estan los archivos que me mostraste que necesitan traducción?

@shargon
Copy link
Member

shargon commented Feb 17, 2018

@dbucci24 Utiliza el canal de discord 🙏 . El tema de las traducciones no tienen nada que ver con este Pull Request. Por conservar el orden mas que nada.

Si tienes alguna duda no dudes en escribirme en discord Shargon#1912

Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants