-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TransactionInvocation.GetScript to StateReader #170
Conversation
This allows smart contracts to check that the transaction is an invocation to the same contract during verification phase. Example use case: neo-project/proposals#18 (comment)
neo/SmartContract/StateReader.cs
Outdated
@@ -104,6 +104,8 @@ public StateReader() | |||
Register("Neo.Transaction.GetOutputs", Transaction_GetOutputs); | |||
Register("Neo.Transaction.GetReferences", Transaction_GetReferences); | |||
Register("Neo.Transaction.GetUnspentCoins", Transaction_GetUnspentCoins); | |||
Register("Neo.Transaction.GetUnspentCoins", Transaction_GetUnspentCoins); | |||
Register("Neo.InvocationTransaction.GetScript", InvocationTransaction_GetScript); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be Register("Neo.Transaction.GetScript", Transaction_GetScript)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, only the subclass InvocationTransaction
has the Script
property. can we still just use Transaction
?
@erikzhang |
@dbucci24 no, quedan partes por traducir y mejorar. Si quieres contacta conmigo en discord nick 'jonatan' y unimos fuerzas. |
@jonatanblockchain ahi te escribi en discord, pero no estoy seguro si eres tu, hay varios 'jonatan' :p |
tengo el mismo avatar! |
@jonatanblockchain no te encuentro!! agregame: DavidB24 |
yo tampoco, si estas en el discord de NEO, en el canal csharp, deberias ver un mensaje mio. |
no estoy en el grupo, mi tag para encontrarme es #9227, sino pasame el tuyo :) |
@jonatanblockchain me podrías decir en que carpeta estan los archivos que me mostraste que necesitan traducción? |
@dbucci24 Utiliza el canal de discord 🙏 . El tema de las traducciones no tienen nada que ver con este Pull Request. Por conservar el orden mas que nada. Si tienes alguna duda no dudes en escribirme en discord |
This allows smart contracts to check that the transaction is
an invocation to the same contract during verification phase.
Example use case: neo-project/proposals#18 (comment)