Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IndexOutOfRangeExceptions from IsMultiSigContract #1890

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Fix IndexOutOfRangeExceptions from IsMultiSigContract #1890

merged 2 commits into from
Aug 31, 2020

Conversation

shargon
Copy link
Member

@shargon shargon commented Aug 31, 2020 •
edited
Loading

Close #1889

@shargon shargon mentioned this pull request Aug 31, 2020
Closed
erikzhang
erikzhang previously approved these changes Aug 31, 2020
View reviewed changes
@shargon @ixje
Update tests/neo.UnitTests/SmartContract/UT_Helper.cs
8da222f 
Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
@shargon shargon requested a review from erikzhang August 31, 2020 12:28
@shargon shargon merged commit 9322675 into neo-project:master Aug 31, 2020
@shargon shargon deleted the fix-1889 branch August 31, 2020 17:56
@danwbyrne danwbyrne mentioned this pull request Dec 18, 2020
Closed
45 tasks
@danwbyrne danwbyrne mentioned this pull request Dec 29, 2020
Closed
12 tasks
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@shargon @ixje
Fix IndexOutOfRangeExceptions from IsMultiSigContract (neo-project#1890)
cc4fb43 
* Fix

* Update tests/neo.UnitTests/SmartContract/UT_Helper.cs

Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>

Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@shargon @ixje @cloud8little
Fix IndexOutOfRangeExceptions from IsMultiSigContract (neo-project#1890)
978c4ec 
* Fix

* Update tests/neo.UnitTests/SmartContract/UT_Helper.cs

Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>

Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixje ixje ixje requested changes

@erikzhang erikzhang erikzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IsMultiSigContract() helper function can throw exceptions
3 participants
@shargon @ixje @erikzhang