Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oracle InsufficientFunds code #2037

Merged
merged 10 commits into from
Nov 8, 2020
Merged

Add oracle InsufficientFunds code #2037

merged 10 commits into from
Nov 8, 2020

Conversation

Tommo-L
Copy link
Contributor

@Tommo-L Tommo-L commented Oct 29, 2020 •
edited
Loading

@erikzhang
Copy link
Member

If the fund is insufficient, the contract will fail to execute, right?

@Tommo-L
Copy link
Contributor Author

Tommo-L commented Oct 29, 2020

If the fund is insufficient, the contract will fail to execute, right?

Yes, but it'll still be packaged in block.

@erikzhang
Copy link
Member

If the request transaction failed to execute, there is no request be stored. Then this OracleResponseCode will never be used.

@Tommo-L
Copy link
Contributor Author

Tommo-L commented Oct 30, 2020

The response transaction maybe be insufficientfund, like the data returned exceeds the size limit.
https://github.com/neo-project/neo-modules/pull/326/files#diff-37804ea315e32b33105846c7a13e577d4c35c56f10ce122db763c2b5a248581dR333-R337

@erikzhang
Copy link
Member

like the data returned exceeds the size limit.

That should be ResponseTooLarge.

@Tommo-L
Copy link
Contributor Author

Tommo-L commented Oct 31, 2020

I think we need both, as the data may also exceed the current fee limit.

shargon
shargon previously approved these changes Nov 1, 2020
View reviewed changes
@superboyiii
Copy link
Member

Ready to merge?

@erikzhang
Copy link
Member

Should we add ConsensusUnreachable?

https://www.example.com/getrandom

@Tommo-L
Copy link
Contributor Author

Tommo-L commented Nov 7, 2020

Should we add ConsensusUnreachable?

https://www.example.com/getrandom

Yes, it should be added.

@shargon shargon merged commit 5d5bd02 into neo-project:master Nov 8, 2020
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 9, 2020
@roman-khimov
transaction: add new oracle response codes
2f0cbcf 
Follow neo-project/neo#2037.
@roman-khimov roman-khimov mentioned this pull request Nov 9, 2020
Merged
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 9, 2020
@roman-khimov
transaction: add new oracle response codes
a1ce3d2 
Follow neo-project/neo#2037.
@danwbyrne danwbyrne mentioned this pull request Dec 18, 2020
Closed
45 tasks
@danwbyrne danwbyrne mentioned this pull request Dec 29, 2020
Closed
5 tasks
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@Tommo-L @shargon @erikzhang
Add oracle InsufficientFunds code (neo-project#2037)
7608a15 
* add InsufficientFunds code

* add ResponseTooLarge

* Update OracleResponseCode.cs

* Change values

Co-authored-by: Tommo-L <luchuan@neo.org>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Erik Zhang <erik@neo.org>
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@Tommo-L @shargon
@erikzhang @cloud8little
Add oracle InsufficientFunds code (neo-project#2037)
3a16cbc 
* add InsufficientFunds code

* add ResponseTooLarge

* Update OracleResponseCode.cs

* Change values

Co-authored-by: Tommo-L <luchuan@neo.org>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Erik Zhang <erik@neo.org>
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 2, 2021
@ixje
https://github.com/neo-project/neo/pull/2037
91a6308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@erikzhang erikzhang erikzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tommo-L @erikzhang @superboyiii @shargon