Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Addr messages if we didn't send GetAddr #2097

Merged
merged 1 commit into from Nov 25, 2020
Merged

Drop Addr messages if we didn't send GetAddr #2097

merged 1 commit into from Nov 25, 2020

Conversation

erikzhang
Copy link
Member

No description provided.

vncoelho
vncoelho reviewed Nov 24, 2020
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and simple, this can avoid filling the queue and analyzing unnecessary messages.

@erikzhang
Copy link
Member Author

致谢信息

该漏洞发现者是腾讯安全玄武实验室的安全研究员梁明月。

@erikzhang erikzhang merged commit 0880ed7 into master Nov 25, 2020
@erikzhang erikzhang deleted the optimize/getaddr branch November 25, 2020 07:17
roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 25, 2020
@roman-khimov
network: treat unsolicited addr commands as errors
2ce3c8b 
See neo-project/neo#2097.
@roman-khimov roman-khimov mentioned this pull request Nov 25, 2020
Merged
@ProDog
Copy link
Contributor

ProDog commented Nov 26, 2020

I got a run error:

image

System.IndexOutOfRangeException
  HResult=0x80131508
  Message=Index was outside the bounds of the array.
  Source=Neo
  StackTrace:
   at Neo.Network.P2P.RemoteNode.SendMessage(Message message) in D:\neo_code\neo\src\neo\Network\P2P\RemoteNode.cs:line 201
   at Neo.Network.P2P.RemoteNode.CheckMessageQueue() in D:\neo_code\neo\src\neo\Network\P2P\RemoteNode.cs:line 58
   at Neo.Network.P2P.RemoteNode.EnqueueMessage(Message message) in D:\neo_code\neo\src\neo\Network\P2P\RemoteNode.cs:line 103
   at Neo.Network.P2P.RemoteNode.OnReceive(Object message) in D:\neo_code\neo\src\neo\Network\P2P\RemoteNode.cs:line 136
   at Akka.Actor.UntypedActor.Receive(Object message)
   at Akka.Actor.ActorBase.AroundReceive(Receive receive, Object message)
   at Akka.Actor.ActorCell.ReceiveMessage(Object message)
   at Akka.Actor.ActorCell.Invoke(Envelope envelope)

@erikzhang
Copy link
Member Author

Should be fixed by #2105

ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@erikzhang
Drop Addr messages if we didn't send GetAddr (neo-project#2097)
ae09c33
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@erikzhang @cloud8little
Drop Addr messages if we didn't send GetAddr (neo-project#2097)
867f652
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho approved these changes

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erikzhang @ProDog @shargon @vncoelho